Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hopefully disable the markdown link checker #154

Merged
merged 1 commit into from Dec 11, 2019
Merged

Hopefully disable the markdown link checker #154

merged 1 commit into from Dec 11, 2019

Conversation

ghost
Copy link

@ghost ghost commented Dec 11, 2019

Changes

This will (hopefully!) disable the markdown link checker that is currently blocking a couple PRs over in the Pipelines repo.

🤞

Submitter Checklist

These are the criteria that every PR should meet, please check them off as you
review them:

@tekton-robot tekton-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Dec 11, 2019
The markdown link checker is currently blocking merge on a couple
PRs in the pipelines repo.

This change will (hopefully) stop that link checker from doing those
checks.

It's a nice feature in principle but causing a bit of pain today.
@tekton-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dibyom

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tekton-robot tekton-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 11, 2019
@pritidesai
Copy link
Member

thanks @sbwsg, hoping for the ⛑
/lgtm

@tekton-robot tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Dec 11, 2019
@tekton-robot tekton-robot merged commit 290f115 into tektoncd:master Dec 11, 2019
@vdemeester
Copy link
Member

@sbwsg thanks for the quick fix 👼. My feeling is, this linter is useful for internal link (in the docs, from on .md to the other), so we need to dig how we can have only that part working 👼 😛

@dibyom
Copy link
Member

dibyom commented Dec 12, 2019

Opened #157 to track the issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants