Migrate the namespace cleanup template CD service to workspaces #1159
Conversation
Namespace cleanup template relies on the cluster PipelineResource to target deployments of resources. Migrate that to workspaces: a secret stored in the cluster bound through a workspace is used to target the deployment. Secrets have been preprovisioned on the cluster, their name is tektoncd-, their type is kubeconfig. See tektoncd#887 for more details. The change is implemented so that the template interface does not change and thus all existing cronjobs are still valid. Signed-off-by: Andrea Frittoli <andrea.frittoli@uk.ibm.com>
tekton-robot
added
the
kind/misc
tekton-robot
added
the
size/M
|
/test check-pr-has-kind-label |
|
@afrittoli: The specified target(s) for
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/approve |
tekton-robot
added
the
approved
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: abayer, vdemeester The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Changes
Namespace cleanup template relies on the cluster PipelineResource
to target deployments of resources.
Migrate that to workspaces: a secret stored in the cluster bound
through a workspace is used to target the deployment.
Secrets have been preprovisioned on the cluster, their name is
tektoncd-, their type is kubeconfig.
See #887 for more details.
The change is implemented so that the template interface does not
change and thus all existing cronjobs are still valid.
Signed-off-by: Andrea Frittoli andrea.frittoli@uk.ibm.com
/kind misc
Submitter Checklist
These are the criteria that every PR should meet, please check them off as you
review them:
See the contribution guide
for more details.