Migrate the folder template CD service to workspaces #1157
Merged
+173
−86
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tekton-robot
added
kind/misc
tekton-robot
added
the
size/L
Folder template relies on the cluster PipelineResource to target deployments of resources and git PipelineResource to clone the git repository. Migrate that to workspaces: - the git-clone task from the catalog is used to clone the repo - a secret stored in the cluster bound through a workspace is used to target the deployment Secrets have been preprovisioned on the cluster, their name is tektoncd-<pipeline-resource-name>, their type is kubeconfig. See tektoncd#887 for more details. The interface of the trigger template is untouched, so existing cronjobs will continue to work as they are. Signed-off-by: Andrea Frittoli <andrea.frittoli@uk.ibm.com>
afrittoli
force-pushed
the
migrate_folder_template_workspaces
branch
from
52e85e8 to
57b6807
Compare
afrittoli
changed the title
tekton-robot
removed
the
do-not-merge/work-in-progress
abayer
approved these changes
Jul 21, 2022
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: abayer The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
tekton-robot
added
the
approved
|
/lgtm |
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Folder template relies on the cluster PipelineResource to target
deployments of resources and git PipelineResource to clone the
git repository.
Migrate that to workspaces:
used to target the deployment
Secrets have been preprovisioned on the cluster, their name is
tektoncd-, their type is kubeconfig.
See #887 for more
details.
The change is implemented so that the template interface does not
change and thus all existing cronjobs are still valid.
Signed-off-by: Andrea Frittoli andrea.frittoli@uk.ibm.com
/kind misc
Submitter Checklist
These are the criteria that every PR should meet, please check them off as you
review them:
See the contribution guide
for more details.