Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add first draft of Knative Build migration guide #976

Merged
merged 2 commits into from
Jul 11, 2019

Conversation

imjasonh
Copy link
Member

@imjasonh imjasonh commented Jun 11, 2019

This covers basic differences between Knative resources and the equivalents in Tekton

This does not yet cover deployment of Knative apps using Tekton.

Changes

Adds a basic migration guide to the docs/ directory.

This is a requirement of knative/build#614 to help Knative Build users understand important differences and to be able to migrate their build workloads to Tekton.

Submitter Checklist

These are the criteria that every PR should meet, please check them off as you
review them:

See the contribution guide
for more details.

Release Notes

None.

This covers basic differences between Knative resources and the equivalents in Tekton

This does not yet cover deployment of Knative apps using Tekton.
@googlebot googlebot added the cla: yes Trying to make the CLA bot happy with ppl from different companies work on one commit label Jun 11, 2019
@tekton-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ImJasonH

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tekton-robot tekton-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jun 11, 2019
@imjasonh imjasonh requested a review from vdemeester June 11, 2019 15:01
@imjasonh
Copy link
Member Author

/test pull-tekton-pipeline-build-tests

Copy link
Member

@vdemeester vdemeester left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 🤗 😻

docs/migrating-from-knative-build.md Outdated Show resolved Hide resolved
docs/migrating-from-knative-build.md Show resolved Hide resolved
Copy link
Collaborator

@bobcatfish bobcatfish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great! Sorry for the review delay - If you want someone else to pick this up and make the edits just let me know @imjasonh

I added some docs which might be good to link to if ppl want more info on some of the functionality you're describing.

Can we add a link to this doc from somewhere, maybe from https://github.com/tektoncd/pipeline#want-to-start-using-pipelines ? could call it something innocuous like [Migration guides]()

docs/migrating-from-knative-build.md Outdated Show resolved Hide resolved
docs/migrating-from-knative-build.md Outdated Show resolved Hide resolved
docs/migrating-from-knative-build.md Outdated Show resolved Hide resolved
docs/migrating-from-knative-build.md Outdated Show resolved Hide resolved
docs/migrating-from-knative-build.md Outdated Show resolved Hide resolved
docs/migrating-from-knative-build.md Show resolved Hide resolved
@bobcatfish
Copy link
Collaborator

woot thanks @imjasonh !

/lgtm
/meow space

@tekton-robot
Copy link
Collaborator

@bobcatfish: cat image

In response to this:

woot thanks @imjasonh !

/lgtm
/meow space

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@tekton-robot tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Jul 11, 2019
@tekton-robot tekton-robot merged commit eaab928 into master Jul 11, 2019
@vdemeester vdemeester deleted the ImJasonH-patch-2 branch July 12, 2019 14:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cla: yes Trying to make the CLA bot happy with ppl from different companies work on one commit lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants