.github/workflows: add a build and test workflows #8577
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tekton-robot
added
release-note-none
vdemeester
force-pushed
the
worfklows-enhancements
branch
5 times, most recently
from
9ec5bd4 to
4e62157
Compare
tekton-robot
added
size/L
vdemeester
force-pushed
the
worfklows-enhancements
branch
6 times, most recently
from
4ec92f8 to
08e535b
Compare
|
This would remove the need for |
|
/hold |
tekton-robot
added
the
do-not-merge/hold
vdemeester
force-pushed
the
worfklows-enhancements
branch
6 times, most recently
from
4312ef5 to
658a6b1
Compare
|
Alright, it takes 27m to run everything. /unhold |
tekton-robot
removed
the
do-not-merge/hold
|
We would need to change the required builds though 🙃 |
vdemeester
force-pushed
the
worfklows-enhancements
branch
from
658a6b1 to
3c62d9f
Compare
|
Plumbing PR for this tektoncd/plumbing#2463 |
2 tasks
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: abayer The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
tekton-robot
added
approved
This commit introduces a new CI workflow in `.github/workflows/ci.yaml` that handles build, linting, testing, and calls the e2e workflows. It optimizes the CI pipeline by including caching mechanisms and consolidates previously separate workflows. The following changes have been made: * Added a multi-stage CI workflow named `ci`. * Introduced linting steps using tools like `gofmt`, `golangci-lint`, `yamllint` and `go-license` check. * Incorporated build, unit tests, and generated code verification. * Added a multi-arch build support configuration. * Consolidated end-to-end tests via a workflow call in `e2e-matrix.yml`. Additionally, the redundant `golangci-lint.yaml` workflow has been removed. Support for a new test target `test-unit-verbose-and-race` is introduced in the `Makefile`, and the Go toolchain in `go.mod` is updated from `go 1.22.3` to `go 1.22.7`. Signed-off-by: Vincent Demeester <vdemeest@redhat.com>
vdemeester
force-pushed
the
worfklows-enhancements
branch
from
3c62d9f to
5c4068c
Compare
tekton-robot
removed
the
needs-rebase
2 tasks
afrittoli
reviewed
Feb 19, 2025
| @@ -0,0 +1,110 @@ | |||
| name: ci | |||
|
|
|||
| on: [pull_request] # yamllint disable-line rule:truthy | |||
There was a problem hiding this comment.
NIT: would be nice to address the lint warnings eventually
| go-version-file: "go.mod" | ||
| - name: build | ||
| run: | | ||
| make test-unit-verbose-and-race |
There was a problem hiding this comment.
Eventually, it would be nice to have all the jobs triggered via a make, for consistency and for ensuring users can run all these locally. I guess that would mean we would need some make equivalent of the setup-go action :]
Comment on lines
+106
to
+107
| KO_DOCKER_REPO=example.com ko resolve -l 'app.kubernetes.io/component!=resolvers' --platform=all --push=false -R -f config 1>/dev/null | ||
| KO_DOCKER_REPO=example.com ko resolve --platform=all --push=false -f config/resolvers 1>/dev/null |
There was a problem hiding this comment.
NIT: I'm not sure this needs to be separated anymore, resolvers are an integral part of our releases now.
This was referenced Feb 19, 2025
This was referenced Mar 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Updated the GitHub Actions workflows to improve naming consistency and
add a new yamllint step. Renamed job names for clarity and removed
unnecessary environment variable in e2e-matrix.yml.
Ports most prow jobs into a set of workflows.
Signed-off-by: Vincent Demeester vdemeest@redhat.com
/kind misc
Submitter Checklist
As the author of this PR, please check off the items in this checklist:
/kind <type>. Valid types are bug, cleanup, design, documentation, feature, flake, misc, question, tepRelease Notes