Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: fix some comments #8524

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

chore: fix some comments #8524

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion pkg/reconciler/pipelinerun/resources/pipelinerunstate.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -658,7 +658,7 @@ func (facts *PipelineRunFacts) GetPipelineTaskStatus() map[string]string {
return tStatus
}

// GetPipelineTaskStatus returns the status of a PipelineFinalTask depending on its taskRun
// GetPipelineFinalTaskStatus returns the status of a PipelineFinalTask depending on its taskRun
func (facts *PipelineRunFacts) GetPipelineFinalTaskStatus() map[string]string {
// construct a map of tasks.<pipelineTask>.status and its state
tStatus := make(map[string]string)
Expand Down
4 changes: 2 additions & 2 deletions test/per_feature_flags_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -70,8 +70,8 @@ func TestPerFeatureFlagOptInAlpha(t *testing.T) {
}
}

// TestPerFeatureFlagOptInBeta tests the behavior with all beta Per-feature
// flags enabled. It first turns ON all beta per-feature flags by default and
// TestFeatureFlagOptInBeta tests the behavior with all beta feature
// flags enabled. It first turns ON all beta feature flags by default and
// turns ON one alpha feature flag at a time to mock opt-in beta test env.
func TestFeatureFlagOptInBeta(t *testing.T) {
configMapData := createExpectedConfigMap(t, false)
Expand Down
Loading