Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(taskrun): resolve issue with TaskRun not failing promptly after Pod OOM #8171

Merged
merged 1 commit into from
Aug 24, 2024
Merged

fix(taskrun): resolve issue with TaskRun not failing promptly after Pod OOM #8171

merged 1 commit into from
Aug 24, 2024

Conversation

l-qing
Copy link
Member

@l-qing l-qing commented Aug 2, 2024 •
edited
Loading

fix #8170

When an OOM occurs in a Pod related to TaskRun, the TaskRun should be marked as failed immediately instead of waiting for it to timeout.

This issue has been present in several recent LTS versions, including v0.53, v0.56, v0.59, and v0.62

Changes

Submitter Checklist

As the author of this PR, please check off the items in this checklist:

  • Has Docs if any changes are user facing, including updates to minimum requirements e.g. Kubernetes version bumps
  • Has Tests included if any functionality added or changed
  • pre-commit Passed
  • Follows the commit message standard
  • Meets the Tekton contributor standards (including functionality, content, code)
  • Has a kind label. You can add one by adding a comment on this PR that contains /kind <type>. Valid types are bug, cleanup, design, documentation, feature, flake, misc, question, tep
  • Release notes block below has been updated with any user facing changes (API changes, bug fixes, changes requiring upgrade notices or deprecation warnings). See some examples of good release notes.
  • Release notes contains the string "action required" if the change requires additional action from users switching to the new release

Release Notes

fix(taskrun): resolve issue with TaskRun not failing promptly after Pod OOM

/kind bug

@tekton-robot tekton-robot added kind/bug Categorizes issue or PR as related to a bug. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Aug 2, 2024
@tekton-robot
Copy link
Collaborator

Hi @l-qing. Thanks for your PR.

I'm waiting for a tektoncd member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

vdemeester
vdemeester approved these changes Aug 2, 2024
View reviewed changes
Copy link
Member

@vdemeester vdemeester left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/ok-to-test

pkg/pod/status.go Outdated Show resolved Hide resolved
@tekton-robot tekton-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Aug 2, 2024
@tekton-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: vdemeester

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tekton-robot tekton-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 2, 2024
@l-qing
Copy link
Member Author

l-qing commented Aug 2, 2024

/retest-required

3 similar comments
@l-qing
Copy link
Member Author

l-qing commented Aug 3, 2024

/retest-required

@l-qing
Copy link
Member Author

l-qing commented Aug 3, 2024

/retest-required

@l-qing
Copy link
Member Author

l-qing commented Aug 3, 2024

/retest-required

@vdemeester
Copy link
Member

cc @tektoncd/core-maintainers

@l-qing l-qing force-pushed the fix/taskrun-pod-oom branch from 876e529 to 46f6671 Compare August 14, 2024 02:19
@chitrangpatel
Copy link
Contributor

/lgtm

@tekton-robot tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Aug 22, 2024
@chitrangpatel
Copy link
Contributor

/retest

1 similar comment
@chitrangpatel
Copy link
Contributor

/retest

@l-qing
Copy link
Member Author

l-qing commented Aug 22, 2024

/retest

Thank you. I'll check the reason for this failure tomorrow.

@l-qing
Copy link
Member Author

l-qing commented Aug 22, 2024

/retest-required

pritidesai
pritidesai reviewed Aug 22, 2024
View reviewed changes
pkg/pod/status.go Outdated Show resolved Hide resolved
@l-qing
fix(taskrun): resolve issue with TaskRun not failing promptly after P…
0083168 
…od OOM

fix tektoncd#8170

When an OOM occurs in a Pod related to TaskRun, the TaskRun should be marked
as failed immediately instead of waiting for it to timeout.
@l-qing l-qing force-pushed the fix/taskrun-pod-oom branch from 46f6671 to 0083168 Compare August 23, 2024 15:44
@tekton-robot tekton-robot removed the lgtm Indicates that a PR is ready to be merged. label Aug 23, 2024
@l-qing
Copy link
Member Author

l-qing commented Aug 23, 2024

The problem of sporadic failures regarding the e2e TestTaskRunFailure has already been addressed in a previous PR: #8174

@l-qing
Copy link
Member Author

l-qing commented Aug 23, 2024

/retest-required

@pritidesai
Copy link
Member

/lgtm

@tekton-robot tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Aug 24, 2024
@l-qing
Copy link
Member Author

l-qing commented Aug 24, 2024

/retest-required

@tekton-robot tekton-robot merged commit b4e8652 into tektoncd:main Aug 24, 2024
14 checks passed
This was referenced Sep 13, 2024
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pritidesai pritidesai pritidesai left review comments

@vdemeester vdemeester vdemeester approved these changes

@afrittoli afrittoli Awaiting requested review from afrittoli

Assignees

@pritidesai pritidesai

@chitrangpatel chitrangpatel

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/bug Categorizes issue or PR as related to a bug. lgtm Indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

The TaskRun did not fail promptly after the Pod experienced OOM
5 participants
@l-qing @tekton-robot @vdemeester @chitrangpatel @pritidesai