Fix git-init failure with git ssh creds 🔑 #804
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: vdemeester The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
tekton-robot
added
approved
In case of a private git resources that uses `ssh` keys, `git` wouldn't find the correct `.ssh/known_hosts`. This only happens in case of the user of the container is `root`. We now treat use `root` as a special case. It should now work for any user — being root or not. Signed-off-by: Vincent Demeester <vdemeest@redhat.com>
vdemeester
force-pushed
the
803-git-init-failure
branch
from
10bacd3 to
45668ad
Compare
1 task
|
/lgtm |
@vdemeester I made a v0.3.1 release, lemme know if this isn't the way we want to go - we could re-release 0.3.0 but folks who have the current/broken 0.3.0 would be left in a strange state |
|
It's great to have a v0.3.1, thanks for doing it so quickly 👍 |
|
Thanks a lot @vdemeester to fix this up so quickly |
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
In case of a private git resources that uses
sshkeys,gitwouldn't find the correct
.ssh/known_hosts. This only happens incase of the user of the container is
root.We now treat use
rootas a special case. It should now work for anyuser — being root or not.
Fixes #803
/cc @chmouel @dlorenc @bobcatfish
release-v0.3.0branchSigned-off-by: Vincent Demeester vdemeest@redhat.com
Submitter Checklist
These are the criteria that every PR should meet, please check them off as you
review them:
See the contribution guide
for more details.
Release Notes