Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[TEP-0142] Support default resolver for Ref to remote StepAction #7345

Merged
merged 1 commit into from
Nov 10, 2023
Merged

[TEP-0142] Support default resolver for Ref to remote StepAction #7345

merged 1 commit into from
Nov 10, 2023

Conversation

Yongxuanzhang
Copy link
Member

@Yongxuanzhang Yongxuanzhang commented Nov 9, 2023 •
edited
Loading

Changes

This commit fixes #7329. It adds the default resolver for the Ref to remote StepAction.

/kind feature

Signed-off-by: Yongxuan Zhang yongxuanzhang@google.com

Submitter Checklist

As the author of this PR, please check off the items in this checklist:

  • Has Docs if any changes are user facing, including updates to minimum requirements e.g. Kubernetes version bumps
  • Has Tests included if any functionality added or changed
  • Follows the commit message standard
  • Meets the Tekton contributor standards (including functionality, content, code)
  • Has a kind label. You can add one by adding a comment on this PR that contains /kind <type>. Valid types are bug, cleanup, design, documentation, feature, flake, misc, question, tep
  • Release notes block below has been updated with any user facing changes (API changes, bug fixes, changes requiring upgrade notices or deprecation warnings). See some examples of good release notes.
  • Release notes contains the string "action required" if the change requires additional action from users switching to the new release

Release Notes

NONE

@tekton-robot
Copy link
Collaborator

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@tekton-robot tekton-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. kind/feature Categorizes issue or PR as related to a new feature. release-note-none Denotes a PR that doesnt merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Nov 9, 2023
@Yongxuanzhang Yongxuanzhang marked this pull request as ready for review November 9, 2023 19:24
@tekton-robot tekton-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Nov 9, 2023
@tekton-robot tekton-robot requested a review from jerop November 9, 2023 19:24
@jerop jerop added this to the Pipelines v0.54 milestone Nov 9, 2023
jerop
jerop reviewed Nov 9, 2023
View reviewed changes
Copy link
Member

@jerop jerop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please add a note in the remote resolution section that default resolvers are supported: https://github.com/tektoncd/pipeline/blob/main/docs/stepactions.md#specifying-remote-stepactions

also, there's a typo in the commit and pr description

@Yongxuanzhang
[TEP-0142] Support default resolver for Ref to remote StepAction
c8d96e4 
This commit fixes tektoncd#7329. It adds the default resolver for the Ref to
remote StepAction.

Signed-off-by: Yongxuan Zhang yongxuanzhang@google.com
QuanZhang-William
QuanZhang-William reviewed Nov 9, 2023
View reviewed changes
Copy link
Member

@QuanZhang-William QuanZhang-William left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@tekton-robot tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Nov 9, 2023
jerop
jerop approved these changes Nov 9, 2023
View reviewed changes
Copy link
Member

@jerop jerop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@tekton-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jerop

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tekton-robot tekton-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 9, 2023
@jerop jerop mentioned this pull request Nov 9, 2023
Closed
20 tasks
@tekton-robot tekton-robot merged commit 63e1a26 into tektoncd:main Nov 10, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@QuanZhang-William QuanZhang-William QuanZhang-William left review comments

@jerop jerop jerop approved these changes

@pritidesai pritidesai Awaiting requested review from pritidesai

@vdemeester vdemeester Awaiting requested review from vdemeester

Assignees

@chitrangpatel chitrangpatel

@jerop jerop

@QuanZhang-William QuanZhang-William

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/feature Categorizes issue or PR as related to a new feature. lgtm Indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesnt merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
Pipelines v0.54
Development

Successfully merging this pull request may close these issues.

TEP-0142: Support default resolver for StepAction remote resolution
5 participants
@Yongxuanzhang @tekton-robot @jerop @QuanZhang-William @chitrangpatel