Clarify docs on pipelinerun timeouts #6171
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tekton-robot
added
kind/documentation
This was referenced Feb 15, 2023
lbernick
force-pushed
the
timeout-docs
branch
2 times, most recently
from
9089469 to
9a8f333
Compare
tekton-robot
added
the
approved
lbernick
force-pushed
the
timeout-docs
branch
from
9a8f333 to
02e18b3
Compare
jkandasa
reviewed
Feb 17, 2023
lbernick
force-pushed
the
timeout-docs
branch
2 times, most recently
from
2c305db to
c46a037
Compare
geriom
suggested changes
Feb 22, 2023
This commit clarifies that `timeouts.tasks` applies to the cumulative time taken by pipeline Tasks, and what behavior is expected when any of the PipelineRun timeouts elapses.
lbernick
force-pushed
the
timeout-docs
branch
from
c46a037 to
5a4427a
Compare
|
I can't lgtm, but /lgtm :) |
jkandasa
approved these changes
Feb 23, 2023
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jerop, jkandasa The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/lgtm |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit clarifies that
timeouts.tasksapplies to the cumulative time taken by pipeline Tasks, and what behavior is expected when any of the PipelineRun timeouts elapses.This should hopefully address some of the confusion in #5849.
Closes #6137
/kind documentation
Submitter Checklist
As the author of this PR, please check off the items in this checklist:
functionality, content, code)
/kind <type>. Valid types are bug, cleanup, design, documentation, feature, flake, misc, question, tepRelease Notes