TEP-119 - Add TaskRun Template in v1 PipelineRun

[JeromeJu]

Changes

This commit adds the TaskRunTemplate in v1 PipelineRun Spec. It moves
the serviceAccountName and podTemplate from PipelineRun Spec. The rest
of the TaskRunTemplate fields are to be implemented after releasing v1.

part of #5302
Implementing TEP-119
/kind feature

Submitter Checklist

As the author of this PR, please check off the items in this checklist:

• [n/a] Has Docs included if any changes are user facing
• Has Tests included if any functionality added or changed
• Follows the commit message standard
• Meets the Tekton contributor standards (including
  functionality, content, code)
• Has a kind label. You can add one by adding a comment on this PR that contains /kind <type>. Valid types are bug, cleanup, design, documentation, feature, flake, misc, question, tep
• Release notes block below has been updated with any user facing changes (API changes, bug fixes, changes requiring upgrade notices or deprecation warnings)
• Release notes contains the string "action required" if the change requires additional action from users switching to the new release

Release Notes

Add `pipelineRun.spec.pipelineTaskRunTemplate` with `serviceAccountName` and `podTemplate`.

[JeromeJu]

Would like to confirm that since for this step we are just moving two fields into a new struct, keeping the existing test cases shall be sufficient with no new unit tests introduced?

/assign @lbernick
cc @yuzp1996

[tekton-robot]

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/apis/pipeline/v1beta1/pipelinerun_conversion.go	95.4%	95.5%	0.0

[tekton-robot]

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/apis/pipeline/v1beta1/pipelinerun_conversion.go	95.4%	95.5%	0.0

[lbernick]

can you please also update the v1beta1 -> v1 migration doc?

[JeromeJu]

can you please also update the v1beta1 -> v1 migration doc?

Thanks @lbernick. Was right about to ask if I can put those changes (including the compute resources renaming) in this #5466 PR?

[lbernick]

can you please also update the v1beta1 -> v1 migration doc?

Thanks @lbernick. Was right about to ask if I can put those changes in this #5466 PR?

I'd rather not-- PRs should be self contained and have all the code + docs related to a single change. If you add those docs to your other PR but keep the code changes in this one, when that PR is merged the docs will not match the code.

[tekton-robot]

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/apis/pipeline/v1beta1/pipelinerun_conversion.go	95.4%	95.5%	0.0

[tekton-robot]

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/apis/pipeline/v1beta1/pipelinerun_conversion.go	95.4%	95.5%	0.0

[tekton-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lbernick

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [lbernick]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[vdemeester]

The rest of the TaskRunTemplate fields are to be implemented after releasing v1.

I am not sure I understand why "after" ?

[JeromeJu]

Thanks @vdemeester for the comment. My take is that PodTemplate and ServiceAccountName are moved before the release to avoid back compatible issues as we would not want to support them in v1 pipelinerun.spec. Could you help confirm my understanding here @lbernick ?

[tekton-robot]

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/apis/pipeline/v1beta1/pipelinerun_conversion.go	95.4%	95.5%	0.0

[lbernick]

Thanks @vdemeester for the comment. My take is that PodTemplate and ServiceAccountName are moved before the release to avoid back compatible issues as we would not want to support them in v1 pipelinerun.spec. Could you help confirm my understanding here @lbernick ?

Yes. The distinction here is that we don't have a great way to support the planned new fields taskRunTemplate.metadata, taskRunTemplate.computeResources, etc, until we swap the stored version of our CRDs to v1. However, this isn't something the user needs to know about, so I suggest removing the line from the docs about when those features will be added.

[tekton-robot]

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/apis/pipeline/v1beta1/pipelinerun_conversion.go	95.4%	95.5%	0.0

[abayer]

/lgtm