Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TEP-0118: matrix: add matrix.params field #5383

Merged
merged 1 commit into from
Sep 9, 2022
Merged

TEP-0118: matrix: add matrix.params field #5383

merged 1 commit into from
Sep 9, 2022

Conversation

chengjoey
Copy link
Member

@chengjoey chengjoey commented Aug 26, 2022 •
edited by jerop
Loading

Changes

TEP-0118 proposed move the existing array of Parameters to a field - params - within the matrix field

In this change, we move the existing field - params - within the matrix

API changes

  1. move the existing array of Parameters to a field - params - within the matrix : params

TODO

add include filed within the matrix and implement include specific combinations in the Matrix

Submitter Checklist

As the author of this PR, please check off the items in this checklist:

  • Has Docs included if any changes are user facing
  • Has Tests included if any functionality added or changed
  • Follows the commit message standard
  • Meets the Tekton contributor standards (including
    functionality, content, code)
  • Has a kind label. You can add one by adding a comment on this PR that contains /kind <type>. Valid types are bug, cleanup, design, documentation, feature, flake, misc, question, tep
  • Release notes block below has been updated with any user facing changes (API changes, bug fixes, changes requiring upgrade notices or deprecation warnings)
  • Release notes contains the string "action required" if the change requires additional action from users switching to the new release

Release Notes

action required: matrixed params must be moved under `matrix.params`

@tekton-robot tekton-robot added do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Aug 26, 2022
@tekton-robot
Copy link
Collaborator

Hi @chengjoey. Thanks for your PR.

I'm waiting for a tektoncd member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@chengjoey chengjoey force-pushed the feat/tep-0118-matrix branch from e550b3c to 74a1822 Compare August 26, 2022 07:40
@tekton-robot tekton-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Aug 26, 2022
@chengjoey
Copy link
Member Author

/kind feature

@tekton-robot tekton-robot added the kind/feature Categorizes issue or PR as related to a new feature. label Aug 26, 2022
jerop
jerop reviewed Aug 26, 2022
View reviewed changes
Copy link
Member

@jerop jerop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is not just a refactor because it's changing the API by adding a matrix.params field -- please update the commit message, PR description, release notes and documentation to explain the new field

@jerop
Copy link
Member

jerop commented Aug 26, 2022

/ok-to-test

@tekton-robot tekton-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Aug 26, 2022
@tekton-robot
Copy link
Collaborator

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/apis/pipeline/v1beta1/param_types.go 98.1% 98.2% 0.0
pkg/apis/pipeline/v1beta1/pipeline_conversion.go 94.5% 94.6% 0.1
pkg/apis/pipeline/v1beta1/pipeline_types.go 97.0% 97.0% 0.0
pkg/reconciler/pipelinerun/resources/apply.go 98.8% 98.2% -0.6
pkg/reconciler/pipelinerun/resources/pipelinerunresolution.go 94.9% 94.7% -0.2
pkg/reconciler/pipelinerun/resources/validate_params.go 98.7% 96.2% -2.5
pkg/reconciler/taskrun/validate_resources.go 97.7% 97.7% 0.0

@chengjoey chengjoey changed the title TEP-0118: matrix-with-explicit-combinations-of-parameters TEP-0118: matrix: add matrix.params and matrix.include field Aug 27, 2022
@chengjoey
Copy link
Member Author

chengjoey commented Aug 27, 2022 •
edited
Loading

This is not just a refactor because it's changing the API by adding a matrix.params field -- please update the commit message, PR description, release notes and documentation to explain the new field

hi, I have adjusted my PR description replease notes and documentation as suggested, please do some reviewing and give some advice

Updated files docs/matrix.md and examples that users need to face modification

@chengjoey chengjoey force-pushed the feat/tep-0118-matrix branch from 74a1822 to ed86c6c Compare August 27, 2022 08:16
@tekton-robot
Copy link
Collaborator

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/apis/pipeline/v1beta1/param_types.go 98.1% 98.2% 0.0
pkg/apis/pipeline/v1beta1/pipeline_conversion.go 94.5% 94.6% 0.1
pkg/apis/pipeline/v1beta1/pipeline_types.go 97.0% 97.0% 0.0
pkg/reconciler/pipelinerun/resources/apply.go 98.8% 98.2% -0.6
pkg/reconciler/pipelinerun/resources/pipelinerunresolution.go 94.9% 94.7% -0.2
pkg/reconciler/pipelinerun/resources/validate_params.go 98.7% 96.2% -2.5
pkg/reconciler/taskrun/validate_resources.go 97.7% 97.7% 0.0

@chengjoey
Copy link
Member Author

/retest

@lbernick lbernick self-assigned this Aug 29, 2022
@lbernick
Copy link
Member

@chengjoey just updated/clarified your release note to include "action required"-- this string is parsed by our release notes script so it can be more easily highlighted to users

@chengjoey chengjoey force-pushed the feat/tep-0118-matrix branch from ed86c6c to f518990 Compare August 31, 2022 03:07
@chengjoey chengjoey changed the title TEP-0118: matrix: add matrix.params and matrix.include field TEP-0118: matrix: add matrix.params field Aug 31, 2022
@tekton-robot
Copy link
Collaborator

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/apis/pipeline/v1beta1/param_types.go 98.1% 98.2% 0.0
pkg/apis/pipeline/v1beta1/pipeline_conversion.go 94.5% 94.6% 0.1
pkg/apis/pipeline/v1beta1/pipeline_types.go 97.0% 97.0% 0.0
pkg/reconciler/pipelinerun/resources/apply.go 97.8% 97.3% -0.5
pkg/reconciler/pipelinerun/resources/pipelinerunresolution.go 94.9% 94.7% -0.2
pkg/reconciler/pipelinerun/resources/validate_params.go 98.7% 96.2% -2.5
pkg/reconciler/taskrun/validate_resources.go 97.7% 97.7% 0.0

@chengjoey chengjoey force-pushed the feat/tep-0118-matrix branch from f518990 to d7391fb Compare August 31, 2022 03:36
@tekton-robot
Copy link
Collaborator

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/apis/pipeline/v1beta1/param_types.go 98.1% 98.2% 0.0
pkg/apis/pipeline/v1beta1/pipeline_conversion.go 94.5% 94.6% 0.1
pkg/apis/pipeline/v1beta1/pipeline_types.go 97.0% 97.0% 0.0
pkg/reconciler/pipelinerun/resources/apply.go 97.8% 97.3% -0.5
pkg/reconciler/pipelinerun/resources/pipelinerunresolution.go 94.9% 94.7% -0.2
pkg/reconciler/pipelinerun/resources/validate_params.go 98.7% 96.2% -2.5
pkg/reconciler/taskrun/validate_resources.go 97.7% 97.7% 0.0

@chengjoey
Copy link
Member Author

/retest

@tekton-robot
Copy link
Collaborator

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/apis/pipeline/v1/param_types.go 96.3% 94.6% -1.7
pkg/apis/pipeline/v1/pipeline_types.go 95.1% 95.2% 0.0
pkg/apis/pipeline/v1/pipeline_validation.go 99.4% 98.3% -1.1
pkg/apis/pipeline/v1/resultref.go 98.2% 98.3% 0.1
pkg/apis/pipeline/v1beta1/param_types.go 98.1% 98.2% 0.0
pkg/apis/pipeline/v1beta1/pipeline_conversion.go 94.5% 94.7% 0.2
pkg/apis/pipeline/v1beta1/pipeline_types.go 97.0% 97.0% 0.0
pkg/reconciler/pipelinerun/resources/apply.go 97.8% 97.3% -0.5
pkg/reconciler/pipelinerun/resources/pipelinerunresolution.go 94.9% 94.7% -0.2
pkg/reconciler/pipelinerun/resources/validate_params.go 98.7% 96.2% -2.5
pkg/reconciler/taskrun/validate_resources.go 97.7% 97.7% 0.0

@chengjoey
Copy link
Member Author

thank you! Please squash into one commit when you have the chance

Thank you for your memtion, i've squashed commits into one

@tekton-robot tekton-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Sep 1, 2022
@chengjoey chengjoey force-pushed the feat/tep-0118-matrix branch from dc24be8 to 1621839 Compare September 2, 2022 01:39
@tekton-robot tekton-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Sep 2, 2022
@tekton-robot
Copy link
Collaborator

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/apis/pipeline/v1/param_types.go 96.3% 94.6% -1.7
pkg/apis/pipeline/v1/pipeline_types.go 95.1% 95.2% 0.0
pkg/apis/pipeline/v1/pipeline_validation.go 99.4% 98.3% -1.1
pkg/apis/pipeline/v1beta1/param_types.go 98.1% 98.2% 0.0
pkg/apis/pipeline/v1beta1/pipeline_conversion.go 94.5% 94.7% 0.2
pkg/apis/pipeline/v1beta1/pipeline_types.go 97.0% 97.0% 0.0
pkg/reconciler/pipelinerun/resources/apply.go 97.8% 97.3% -0.5
pkg/reconciler/pipelinerun/resources/pipelinerunresolution.go 94.9% 94.7% -0.2
pkg/reconciler/pipelinerun/resources/validate_params.go 98.7% 96.2% -2.5
pkg/reconciler/taskrun/validate_resources.go 97.7% 97.7% 0.0

@chengjoey chengjoey requested a review from jerop September 5, 2022 03:00
@chengjoey chengjoey force-pushed the feat/tep-0118-matrix branch from 1621839 to ee64c10 Compare September 7, 2022 13:42
@tekton-robot
Copy link
Collaborator

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/apis/pipeline/v1/param_types.go 96.3% 94.6% -1.7
pkg/apis/pipeline/v1/pipeline_types.go 96.0% 96.0% 0.0
pkg/apis/pipeline/v1/pipeline_validation.go 99.4% 98.3% -1.1
pkg/apis/pipeline/v1beta1/param_types.go 98.1% 98.2% 0.0
pkg/apis/pipeline/v1beta1/pipeline_conversion.go 94.6% 94.8% 0.2
pkg/apis/pipeline/v1beta1/pipeline_types.go 97.0% 97.0% 0.0
pkg/reconciler/pipelinerun/resources/apply.go 97.8% 97.3% -0.5
pkg/reconciler/pipelinerun/resources/pipelinerunresolution.go 94.9% 94.7% -0.2
pkg/reconciler/pipelinerun/resources/validate_params.go 98.7% 96.2% -2.5
pkg/reconciler/taskrun/validate_resources.go 97.7% 97.7% 0.0

jerop
jerop approved these changes Sep 8, 2022
View reviewed changes
Copy link
Member

@jerop jerop left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@chengjoey thank you and welcome to Tekton!

/lgtm
/meow

@chengjoey would love to learn more about your interest in Matrix and ask if you have any early feedback from using it - couldn't find you on slack, please message me if you'd like to chat 😀

@tekton-robot
Copy link
Collaborator

@jerop: cat image

In response to this:

@chengjoey thank you and welcome to Tekton!

/lgtm
/meow

Would love to learn more about your interest in Matrix and if you have any early feedback on using it - couldn't find you on slack, please message me if you'd like to chat 😀

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@tekton-robot tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Sep 8, 2022
@tekton-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jerop, lbernick

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tekton-robot tekton-robot added release-note-action-required Denotes a PR that introduces potentially breaking changes that require user action. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Sep 8, 2022
@chengjoey chengjoey force-pushed the feat/tep-0118-matrix branch from ee64c10 to 2be6018 Compare September 9, 2022 01:40
@tekton-robot tekton-robot removed lgtm Indicates that a PR is ready to be merged. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Sep 9, 2022
@tekton-robot
Copy link
Collaborator

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/apis/pipeline/v1/param_types.go 96.3% 94.6% -1.7
pkg/apis/pipeline/v1/pipeline_types.go 95.7% 95.7% 0.0
pkg/apis/pipeline/v1/pipeline_validation.go 99.4% 98.3% -1.1
pkg/apis/pipeline/v1beta1/param_types.go 98.1% 98.2% 0.0
pkg/apis/pipeline/v1beta1/pipeline_conversion.go 94.6% 94.8% 0.2
pkg/apis/pipeline/v1beta1/pipeline_types.go 96.8% 96.8% 0.0
pkg/reconciler/pipelinerun/resources/apply.go 97.8% 97.3% -0.5
pkg/reconciler/pipelinerun/resources/pipelinerunresolution.go 94.9% 94.7% -0.2
pkg/reconciler/pipelinerun/resources/validate_params.go 98.7% 96.2% -2.5
pkg/reconciler/taskrun/validate_resources.go 97.7% 97.7% 0.0

@chengjoey
Copy link
Member Author

chengjoey commented Sep 9, 2022 •
edited
Loading

@chengjoey thank you and welcome to Tekton!

/lgtm /meow

@chengjoey would love to learn more about your interest in Matrix and ask if you have any early feedback from using it - couldn't find you on slack, please message me if you'd like to chat 😀

would be mero than happy discuss the matrix with you😀

@chengjoey
Copy link
Member Author

New changes are detected. LGTM label has been removed.

rebase and solve the conflict files

@lbernick
Copy link
Member

lbernick commented Sep 9, 2022

/lgtm

@tekton-robot tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Sep 9, 2022
@tekton-robot tekton-robot merged commit e1fd727 into tektoncd:main Sep 9, 2022
@chengjoey chengjoey mentioned this pull request Jan 27, 2023
Merged
@Yongxuanzhang Yongxuanzhang mentioned this pull request Feb 24, 2023
Merged
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lbernick lbernick lbernick approved these changes

@jerop jerop jerop approved these changes

Assignees

@jerop jerop

@lbernick lbernick

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/feature Categorizes issue or PR as related to a new feature. lgtm Indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. release-note-action-required Denotes a PR that introduces potentially breaking changes that require user action. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@chengjoey @tekton-robot @jerop @lbernick