-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move step and sidecar replacements to new package #5179
Conversation
This commit moves logic related to variable replacement in Steps and Sidecars out of pkg/apis into its own package. This will prevent this code from being duplicated in the v1 api package. No functional changes.
The following is the coverage report on the affected files.
|
/retest |
/test check-pr-has-kind-label |
@lbernick: The specified target(s) for
The following commands are available to trigger optional jobs:
Use In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: vdemeester The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/lgtm |
Changes
This commit moves logic related to variable replacement in Steps and Sidecars
out of pkg/apis into its own package. This will prevent this code from being
duplicated in the v1 api package. No functional changes.
/kind cleanup
Submitter Checklist
As the author of this PR, please check off the items in this checklist:
functionality, content, code)
/kind <type>
. Valid types are bug, cleanup, design, documentation, feature, flake, misc, question, tepRelease Notes