Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Export ValidateObjectKeys function #5073

Merged
merged 1 commit into from
Jul 5, 2022
Merged

Export ValidateObjectKeys function #5073

merged 1 commit into from
Jul 5, 2022

Conversation

chuangw6
Copy link
Member

@chuangw6 chuangw6 commented Jul 4, 2022 •
edited
Loading

Changes

Export this function for chains to use it.
#5072

Submitter Checklist

As the author of this PR, please check off the items in this checklist:

  • Docs included if any changes are user facing
  • Tests included if any functionality added or changed
  • Follows the commit message standard
  • Meets the Tekton contributor standards (including
    functionality, content, code)
  • Release notes block below has been filled in
    (if there are no user facing changes, use release note "NONE")

Release Notes

ValidateObjectKeys function is now available for usage outside the v1beta1 package.

@chuangw6
Export ValidateObjectKeys function
9c15885 
Export this function for chains to use it.
tektoncd#5072
@tekton-robot tekton-robot added the do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. label Jul 4, 2022
@tekton-robot tekton-robot requested review from abayer and lbernick July 4, 2022 21:36
@tekton-robot tekton-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Jul 4, 2022
@chuangw6
Copy link
Member Author

chuangw6 commented Jul 4, 2022

/kind misc

@tekton-robot tekton-robot added the kind/misc Categorizes issue or PR as a miscellaneuous one. label Jul 4, 2022
@chuangw6
Copy link
Member Author

chuangw6 commented Jul 5, 2022

/kind misc

@chuangw6 chuangw6 mentioned this pull request Jul 5, 2022
Closed
@ywluogg
Copy link
Contributor

ywluogg commented Jul 5, 2022

/assign @ywluogg

@ywluogg
Copy link
Contributor

ywluogg commented Jul 5, 2022

/lgtm

@tekton-robot tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Jul 5, 2022
@chuangw6 chuangw6 closed this Jul 5, 2022
@chuangw6 chuangw6 reopened this Jul 5, 2022
@chuangw6
Copy link
Member Author

chuangw6 commented Jul 5, 2022

/test tekton-pipeline-unit-tests

@abayer
Copy link
Contributor

abayer commented Jul 5, 2022

/retest
/approve

@tekton-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: abayer

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tekton-robot tekton-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 5, 2022
@chuangw6
Copy link
Member Author

chuangw6 commented Jul 5, 2022

/retest

@tekton-robot tekton-robot merged commit 6876520 into tektoncd:main Jul 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@abayer abayer Awaiting requested review from abayer

@lbernick lbernick Awaiting requested review from lbernick

Assignees

@ywluogg ywluogg

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/misc Categorizes issue or PR as a miscellaneuous one. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@chuangw6 @ywluogg @abayer @tekton-robot