TEP-0090: Allow setting embedded status feature flag to minimal in tests #5032
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We recently added support for minimal embedded status, which is gated behind the `embedded-status` feature flag. In this change, we support setting `embedded-status` when running end-to-end tests. It defaults to "full" because this is the current default value for the flag.
tekton-robot
added
release-note-none
|
cc @abayer @afrittoli @dibyom please take a look |
|
/approve I assume that the next step after this merges is to add ...to the |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: abayer The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
tekton-robot
added
the
approved
@abayer exactly, you're spoiling the surprise 😁 |
|
heehee. =) |
jerop
added a commit
to jerop/plumbing
that referenced
this pull request
Jun 23, 2022
In tektoncd/pipeline#5032, we added the logic for setting embedded status when running end to end tests. In this change, we set `embedded-status` to `"minimal"` so that we can dogfood the feature alongside other alpha features. This also allows us to run examples with `Matrix` which needs minimal embedded status.
1 task
tekton-robot
pushed a commit
to tektoncd/plumbing
that referenced
this pull request
Jun 23, 2022
In tektoncd/pipeline#5032, we added the logic for setting embedded status when running end to end tests. In this change, we set `embedded-status` to `"minimal"` so that we can dogfood the feature alongside other alpha features. This also allows us to run examples with `Matrix` which needs minimal embedded status.
jerop
changed the title
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
We recently added support for minimal embedded status, which is gated behind the
embedded-statusfeature flag. In this change, we support settingembedded-statuswhen running end-to-end tests. It defaults to "full" because this is the current default value for the flag./kind misc
Submitter Checklist
As the author of this PR, please check off the items in this checklist:
functionality, content, code)
Release Notes