Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor LimitRange package #4992

Merged
merged 1 commit into from
Jun 27, 2022
Merged

Refactor LimitRange package #4992

merged 1 commit into from
Jun 27, 2022

Conversation

lbernick
Copy link
Member

Changes

This commit separates logic for calculating a "virtual" limitrange from all limitranges
present in a namespace from logic for setting pod compute resources based on the virtual limitrange,
and adds tests. This makes it much easier to add tests for scenarios with multiple limitranges
and multiple containers, because each component can be tested separately.

No functional changes.

/kind cleanup

Submitter Checklist

As the author of this PR, please check off the items in this checklist:

  • n/a Docs included if any changes are user facing
  • Tests included if any functionality added or changed
  • Follows the commit message standard
  • Meets the Tekton contributor standards (including
    functionality, content, code)
  • Release notes block below has been filled in
    (if there are no user facing changes, use release note "NONE")

Release Notes

NONE

@tekton-robot tekton-robot added release-note-none Denotes a PR that doesnt merit a release note. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. labels Jun 16, 2022
@tekton-robot tekton-robot requested a review from bobcatfish June 16, 2022 18:11
@tekton-robot tekton-robot added the size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. label Jun 16, 2022
@tekton-robot tekton-robot requested a review from dibyom June 16, 2022 18:11
@lbernick
Copy link
Member Author

@vdemeester @skaegi PTAL

@tekton-robot
Copy link
Collaborator

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/internal/computeresources/limitrange/limitrange.go Do not exist 97.7%
pkg/internal/computeresources/transformer.go Do not exist 91.3%

@lbernick
Copy link
Member Author

/test pull-tekton-pipeline-go-coverage

@tekton-robot
Copy link
Collaborator

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/internal/computeresources/limitrange/limitrange.go Do not exist 97.7%
pkg/internal/computeresources/transformer.go Do not exist 91.3%

@lbernick
Copy link
Member Author

/test pull-tekton-pipeline-alpha-integration-tests

@lbernick
Copy link
Member Author

/test pull-tekton-pipeline-build-tests

skaegi
skaegi approved these changes Jun 17, 2022
View reviewed changes
Copy link
Contributor

@skaegi skaegi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good and more cleanly separates the tests.

@skaegi
Copy link
Contributor

skaegi commented Jun 17, 2022

/assign @lbernick

@skaegi
Copy link
Contributor

skaegi commented Jun 17, 2022

/lgtm

@tekton-robot tekton-robot added lgtm Indicates that a PR is ready to be merged. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Jun 17, 2022
@tekton-robot tekton-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 20, 2022
@tekton-robot tekton-robot removed lgtm Indicates that a PR is ready to be merged. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Jun 27, 2022
@tekton-robot
Copy link
Collaborator

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/internal/computeresources/limitrange/limitrange.go Do not exist 97.7%
pkg/internal/computeresources/transformer.go Do not exist 92.5%

@tekton-robot
Copy link
Collaborator

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/internal/computeresources/limitrange/limitrange.go Do not exist 97.7%

@tekton-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: skaegi, vdemeester

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@skaegi
Copy link
Contributor

skaegi commented Jun 27, 2022

/lgtm

@tekton-robot tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Jun 27, 2022
@lbernick
Refactor LimitRange package
0d2556e 
This commit separates logic for calculating a "virtual" limitrange from all limitranges
present in a namespace from logic for setting pod compute resources based on the virtual limitrange,
and adds tests. This makes it much easier to add tests for scenarios with multiple limitranges
and multiple containers, because each component can be tested separately.

No functional changes.
@tekton-robot tekton-robot removed the lgtm Indicates that a PR is ready to be merged. label Jun 27, 2022
@tekton-robot
Copy link
Collaborator

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/internal/computeresources/limitrange/limitrange.go Do not exist 97.7%
pkg/internal/computeresources/transformer.go Do not exist 92.5%

@skaegi
Copy link
Contributor

skaegi commented Jun 27, 2022

/lgtm
good catch

@tekton-robot tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Jun 27, 2022
@tekton-robot tekton-robot merged commit 067cbb7 into tektoncd:main Jun 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@skaegi skaegi skaegi approved these changes

@vdemeester vdemeester vdemeester approved these changes

@bobcatfish bobcatfish Awaiting requested review from bobcatfish

@dibyom dibyom Awaiting requested review from dibyom

Assignees

@skaegi skaegi

@lbernick lbernick

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm Indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesnt merit a release note. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@lbernick @tekton-robot @skaegi @vdemeester