Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update gopkg.in/yaml.v3 to v3.0.0 #4905

Merged
merged 1 commit into from
May 25, 2022

Conversation

SaschaSchwarze0
Copy link
Contributor

Signed-off-by: Sascha Schwarze schwarzs@de.ibm.com

Fix for CVE-2022-28948, not sure how realistic it is to exploit it. Though, scanning tools don't care that much about that anyway.

Changes

/kind cleanup

Submitter Checklist

As the author of this PR, please check off the items in this checklist:

  • Docs included if any changes are user facing
  • Tests included if any functionality added or changed
  • Follows the commit message standard
  • Meets the Tekton contributor standards (including
    functionality, content, code)
  • Release notes block below has been filled in
    (if there are no user facing changes, use release note "NONE")

Release Notes

NONE

Signed-off-by: Sascha Schwarze <schwarzs@de.ibm.com>
@tekton-robot tekton-robot added release-note-none Denotes a PR that doesnt merit a release note. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. labels May 24, 2022
@tekton-robot tekton-robot requested review from jerop and vdemeester May 24, 2022 12:33
@tekton-robot tekton-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels May 24, 2022
@tekton-robot
Copy link
Collaborator

Hi @SaschaSchwarze0. Thanks for your PR.

I'm waiting for a tektoncd member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@imjasonh
Copy link
Member

/lgtm

Thanks!

@vdemeester @afrittoli Are we still planning/hoping to enable dependabot across Tekton repos?

@tekton-robot tekton-robot added the lgtm Indicates that a PR is ready to be merged. label May 24, 2022
@pritidesai
Copy link
Member

@vdemeester @afrittoli Are we still planning/hoping to enable dependabot across Tekton repos?

yup we should 👍 how can we proceed with enabling it? Chains has it enabled already: https://github.com/tektoncd/chains/pulls/app%2Fdependabot

How does it work though? dependabot has a PR to upgrade github.com/hashicorp/go-plugin from v1.4.3 to v1.4.4 but not for pipelines 🤔

github.com/tektoncd/pipeline v0.31.1

Copy link
Member

@pritidesai pritidesai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you @SaschaSchwarze0 👍

@tekton-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: pritidesai

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tekton-robot tekton-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 25, 2022
@pritidesai
Copy link
Member

/ok-to-test

@tekton-robot tekton-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels May 25, 2022
@SaschaSchwarze0
Copy link
Contributor Author

/test pull-tekton-pipeline-integration-tests

@SaschaSchwarze0
Copy link
Contributor Author

@vdemeester @afrittoli Are we still planning/hoping to enable dependabot across Tekton repos?

yup we should 👍 how can we proceed with enabling it? Chains has it enabled already: https://github.com/tektoncd/chains/pulls/app%2Fdependabot

How does it work though? dependabot has a PR to upgrade github.com/hashicorp/go-plugin from v1.4.3 to v1.4.4 but not for pipelines 🤔

github.com/tektoncd/pipeline v0.31.1

You need a dependabot.yaml. But note that (for whatever reason), Dependabot did not notify us of this one (in Shipwright). But it was also quite new, maybe our downstream notification came just quicker than Dependabot became aware of it.

@tekton-robot tekton-robot merged commit a67eee4 into tektoncd:main May 25, 2022
@SaschaSchwarze0 SaschaSchwarze0 deleted the sascha-update-yaml-v3 branch May 31, 2022 09:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm Indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. release-note-none Denotes a PR that doesnt merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants