Fix validateNoDuplicateNames

[chuangw6]

Changes

Fixes #4814

Prior to this fix, validateNoDuplicateNames function was intended to check case-insensitive duplications against names, but it saved original names into the set to compare, which can cause that duplicate names cannot be checked correctly - mentioned in #4814.

In this fix:

• validateNoDuplicateNames will save names in lower case into the check set and then compare.
• Unit tests are added for this fix.
• Document that parameter names are case insensitive in the docs/tasks.md file and add links to this file's Specifying Parameters section in other relevant files.

Submitter Checklist

As the author of this PR, please check off the items in this checklist:

• Docs included if any changes are user facing
• Tests included if any functionality added or changed
• Follows the commit message standard
• Meets the Tekton contributor standards (including
  functionality, content, code)
• Release notes block below has been filled in
  (if there are no user facing changes, use release note "NONE")

Release Notes

[chuangw6]

/assign @dibyom

[jerop]

thanks for this fix @chuangw6!

please add more context to the commit message and PR description per the commit message standards, which can include the detail that the function was intended to be case insensitive as demonstrated by lines 150 and 155 below:

pipeline/pkg/apis/pipeline/v1beta1/taskrun_validation.go

Lines 150 to 155 in 6f39e94

	// Case insensitive.
	// If byIndex is true, the error will be reported by index instead of by key.
	func validateNoDuplicateNames(names []string, byIndex bool) (errs *apis.FieldError) {
	seen := sets.NewString()
	for i, n := range names {
	if seen.Has(strings.ToLower(n)) {

also, please add documentation that the params are case-insensitive (skimmed through the docs and they don't seem to mention this)

[dibyom]

LGTM!
We should definitely update the docs to mention params are case insensitive

[chuangw6]

thanks for this fix @chuangw6!

please add more context to the commit message and PR description per the commit message standards, which can include the detail that the function was intended to be case insensitive as demonstrated by lines 150 and 155 below:

pipeline/pkg/apis/pipeline/v1beta1/taskrun_validation.go

Lines 150 to 155 in 6f39e94

	// Case insensitive.
	// If byIndex is true, the error will be reported by index instead of by key.
	func validateNoDuplicateNames(names []string, byIndex bool) (errs *apis.FieldError) {
	seen := sets.NewString()
	for i, n := range names {
	if seen.Has(strings.ToLower(n)) {

also, please add documentation that the params are case-insensitive (skimmed through the docs and they don't seem to mention this)

Thanks! Done!

[tekton-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dibyom, vdemeester

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [dibyom,vdemeester]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[abayer]

/lgtm

[abayer]

/retest