Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

release: Drop windows from pipeline-wide platforms #4308

Merged
merged 1 commit into from
Oct 13, 2021
Merged

release: Drop windows from pipeline-wide platforms #4308

merged 1 commit into from
Oct 13, 2021

Conversation

imjasonh
Copy link
Member

Since we don't want to build the base image for windows, only entrypoint, don't include this in the pipeline-wide default.

/kind bug

Changes

Submitter Checklist

As the author of this PR, please check off the items in this checklist:

  • Docs included if any changes are user facing
  • Tests included if any functionality added or changed
  • Follows the commit message standard
  • Meets the Tekton contributor standards (including
    functionality, content, code)
  • Release notes block below has been filled in or deleted (only if no user facing changes)

Release Notes

NONE

@imjasonh
release: Drop windows from pipeline-wide platforms
bfd676c 
Since we don't want to build the base image for windows, only entrypoint, don't include this in the pipeline-wide default.
@tekton-robot tekton-robot added release-note-none Denotes a PR that doesnt merit a release note. kind/bug Categorizes issue or PR as related to a bug. labels Oct 13, 2021
@tekton-robot tekton-robot requested review from dlorenc and jerop October 13, 2021 17:31
@tekton-robot tekton-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Oct 13, 2021
@abayer
Copy link
Contributor

abayer commented Oct 13, 2021

/lgtm

@tekton-robot tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Oct 13, 2021
@imjasonh
Copy link
Member Author

/test pull-tekton-pipeline-integration-tests

pritidesai
pritidesai approved these changes Oct 13, 2021
View reviewed changes
Copy link
Member

@pritidesai pritidesai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you @imjasonh

@tekton-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: pritidesai

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tekton-robot tekton-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 13, 2021
@tekton-robot tekton-robot merged commit 405c009 into main Oct 13, 2021
@vdemeester vdemeester deleted the imjasonh-patch-1 branch March 22, 2023 16:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pritidesai pritidesai pritidesai approved these changes

@dlorenc dlorenc Awaiting requested review from dlorenc

@jerop jerop Awaiting requested review from jerop

Assignees

@abayer abayer

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/bug Categorizes issue or PR as related to a bug. lgtm Indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesnt merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@imjasonh @abayer @tekton-robot @pritidesai