Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add disable-creds-init property for feature-flags setting #3573

Merged
merged 1 commit into from
Dec 1, 2020
Merged

Add disable-creds-init property for feature-flags setting #3573

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion docs/install.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ This guide explains how to install Tekton Pipelines. It covers the following top
* [Configuring PipelineResource storage](#configuring-pipelineresource-storage)
* [Customizing basic execution parameters](#customizing-basic-execution-parameters)
* [Configuring High Availability](#configuring-high-availability)
* [Configuring tekton pipeline controller performance](#configuring-tekton-pipeline-controller-performance)
* [Configuring Tekton pipeline controller performance](#configuring-tekton-pipeline-controller-performance)
* [Creating a custom release of Tekton Pipelines](#creating-a-custom-release-of-tekton-pipelines)
* [Next steps](#next-steps)

Expand Down Expand Up @@ -349,6 +349,10 @@ not running.
disabled (`"false"`), which means it is disallowed to use the
`bundle` field.

- `disable-creds-init` - set this flag to `"true"` to [disable Tekton's built-in credential initialization](auth.md#disabling-tektons-built-in-auth)
and use Workspaces to mount credentials from Secrets instead.
The default is `false`. For more information, see the [associated issue](https://github.com/tektoncd/pipeline/issues/3399).
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggest linking to the section of auth.md that describes this feature instead. https://github.com/tektoncd/pipeline/blob/master/docs/auth.md#disabling-tektons-built-in-auth

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @sbwsg ,

I linked that document above in the PR [disable Tekton's built-in credential initialization](auth.md#disabling-tektons-built-in-auth)

Is that what you are looking for?

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh haha 😅, sorry, I missed that.


For example:

```yaml
Expand Down