Move Resources implementation to their package 🎗 #2103
Conversation
googlebot
added
the
cla: yes
tekton-robot
added
the
size/XXL
|
/kind cleanup |
tekton-robot
added
kind/cleanup
|
The following is the coverage report on pkg/.
|
vdemeester
force-pushed
the
move-resource-impl
branch
from
916cc5b to
29ec837
Compare
|
The following is the coverage report on pkg/.
|
|
Opened #2105 to reduce the size of this PR 👼 |
|
/test pull-tekton-pipeline-integration-tests |
GitResource, ImageResource, … are PipelineResource implementation and are not really part of the API. At least, they shouldn't be part of the `pkg/apis/pipeline` package. This moves those to their own packages under `pkg/apis/resource/v1alpha1`: - `cloudevent` for `CloudEventResource` - `cluster` for `ClusterResource` - `git` for `GitResource` - `image` for `ImageResource` - `pullrequest` for `PullRequestResource` - `storage` for all the storage resources `GCSResource`, `BuildGCSResource` and `ArtifactBucket`, `ArtifactPVC` This renames the struct (to make lint and I happy 😌) and moves `v1alpha1.ResourceFromType` to `resource.FromType` Signed-off-by: Vincent Demeester <vdemeest@redhat.com>
vdemeester
force-pushed
the
move-resource-impl
branch
from
29ec837 to
b32a43f
Compare
| return storageVol | ||
| } | ||
|
|
||
| // of the step will include name. |
There was a problem hiding this comment.
oh yeah indeed.. what happened there…
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: sbwsg The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
tekton-robot
added
the
approved
|
Awesome! Thanks for cleaning this up @vdemeester :D Quick question: I don't quite understand why there are changes in |
I don't either… it got changed when I ran |
| @@ -1,5 +1,5 @@ | |||
| /* | |||
| Copyright 2019 The Tekton Authors | |||
| Copyright 2019-2020 The Tekton Authors | |||
|
/lgtm |
|
/retest |
Changes
GitResource, ImageResource, … are PipelineResource implementation and
are not really part of the API. At least, they shouldn't be part of
the
pkg/apis/pipelinepackage.This moves those to their own packages under
pkg/apis/resource/v1alpha1:cloudeventforCloudEventResourceclusterforClusterResourcegitforGitResourceimageforImageResourcepullrequestforPullRequestResourcestoragefor all the storage resourcesGCSResource,BuildGCSResourceandArtifactBucket,ArtifactPVCThis renames the struct (to make lint and I happy 😌) and moves
v1alpha1.ResourceFromTypetoresource.FromTypeSigned-off-by: Vincent Demeester vdemeest@redhat.com
/cc @afrittoli @sbwsg @bobcatfish @skaegi
Submitter Checklist
These are the criteria that every PR should meet, please check them off as you
review them:
See the contribution guide for more details.
Double check this list of stuff that's easy to miss:
cmddir, please updatethe release Task to build and release this image.
Reviewer Notes
If API changes are included, additive changes must be approved by at least two OWNERS and backwards incompatible changes must be approved by more than 50% of the OWNERS, and they must first be added in a backwards compatible way.
Release Notes