-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WIP: Move LimitRange Examples Out of no-ci Folder #2102
WIP: Move LimitRange Examples Out of no-ci Folder #2102
Conversation
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/test pull-tekton-pipeline-integration-tests |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@danielhelfand I wonder if it make sense to move them from no-ci
, as with this, we only validate the yaml, we are not doing any check on if it ran successfully or not
kind: LimitRange | ||
metadata: | ||
name: limit-mem-cpu-per-container | ||
namespace: pipelinerun-limitrange-ns |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Our "check" won't check this though, as "did it run sucessfully", as, it only look into the current namespace (default
or one created by the CI 🤔).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
By chance, do you know if other namespaces could be added to check?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
By chance, do you know if other namespaces could be added to check?
Yep they could 👼
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let me look into e2e-common.sh and see what I can do to try and add the results.
Closing this in favor of adding something to go e2e tests |
Closes #2071
When these examples were originally introduced, they needed to be located under the
no-ci
folder since the examples created a LimitRange that caused other examples to fail. At the time, the implementation for using LimitRanges required users to specify aLimitRangeName
on the PipelineRunSpec or TaskRunSpec. No other examples did this, which caused failures during integration tests. All these examples should now be able to succeed even with a LimitRange in place since no LimitRangeName is needed to be specified (#2020).I think what makes sense is to namespace these examples as discussed in this issue in plumbing and keep other examples all running in a particular namespace. Not sure if this would require anything different to detect for failures of these examples since they are in different namepaces than other examples, but my thought would be to have these serve as a form of e2e testing for LimitRanges.
Submitter Checklist
Reviewer Notes
If API changes are included, additive changes must be approved by at least two OWNERS and backwards incompatible changes must be approved by more than 50% of the OWNERS, and they must first be added in a backwards compatible way.
Release Notes