Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use vendor folder to speed up CI 🥄 #2040

Merged
merged 1 commit into from
Feb 18, 2020
Merged

Use vendor folder to speed up CI 🥄 #2040

merged 1 commit into from
Feb 18, 2020

Conversation

vdemeester
Copy link
Member

@vdemeester vdemeester commented Feb 12, 2020 •
edited
Loading

Changes

We still are using the vendor folder, so the CI should use this to
build instead of trying to download the world.

  • It will speed up the CI
  • It will make sure we can build and test with what's in vendor

This also updates release Task(s) and Pipeline(s) to use the vendor folder.

/hold

/cc @afrittoli

Signed-off-by: Vincent Demeester vdemeest@redhat.com

Submitter Checklist

These are the criteria that every PR should meet, please check them off as you
review them:

See the contribution guide for more details.

Double check this list of stuff that's easy to miss:

Reviewer Notes

If API changes are included, additive changes must be approved by at least two OWNERS and backwards incompatible changes must be approved by more than 50% of the OWNERS, and they must first be added in a backwards compatible way.

@tekton-robot tekton-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 12, 2020
@googlebot googlebot added the cla: yes Trying to make the CLA bot happy with ppl from different companies work on one commit label Feb 12, 2020
@tekton-robot tekton-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Feb 12, 2020
@vdemeester
Copy link
Member Author

Example for unit-test: before 7m59s, on this PR 3m59s

@dibyom
Copy link
Member

dibyom commented Feb 13, 2020

/test pull-tekton-pipeline-integration-tests

@vdemeester
Copy link
Member Author

integration-test: before 58m8s, on this PR 30m51s
build-test: before 1h9m, on this PR 22m35s (seems a bit fishy.. I may have taken a weird build)

@vdemeester
Copy link
Member Author

Depends on tektoncd/plumbing#232

@tekton-robot tekton-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Feb 17, 2020
@tekton-robot tekton-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Feb 17, 2020
@vdemeester
Use vendor folder to speed up CI 🥄
5a5c28d 
We still are using the `vendor` folder, so the CI should use this to
build instead of trying to download the world.

- It will speed up the CI
- It will make sure we can build and test with what's in `vendor`

This also updates release Task(s) and Pipeline(s) to use the `vendor` folder.

Signed-off-by: Vincent Demeester <vdemeest@redhat.com>
@vdemeester
Copy link
Member Author

/retest

@vdemeester
Copy link
Member Author

build-test: 14m3s — with still room for improvements (we should split this most likely as.. it does way more than build.. we may want to have a build-test and a lint-test.. )
unit-tests: 3m43s
integration-tests: 28m13s

For comparison : #2059
build-test: 34m31s
unit-tests: 6m19s
integration-tests: 21m12s

The integration-tests time depends on a lot of things (aka boskos, cluster provisionning, …)

@chmouel
Copy link
Member

chmouel commented Feb 18, 2020

/lgtm

@tekton-robot tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Feb 18, 2020
@vdemeester
Copy link
Member Author

/hold cancel

@tekton-robot tekton-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 18, 2020
@abayer
Copy link
Contributor

abayer commented Feb 18, 2020

/approve

@tekton-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: abayer

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tekton-robot tekton-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 18, 2020
@tekton-robot tekton-robot merged commit ac5019a into tektoncd:master Feb 18, 2020
@vdemeester vdemeester deleted the use-vendor branch February 18, 2020 14:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@afrittoli afrittoli Awaiting requested review from afrittoli

Assignees

@chmouel chmouel

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cla: yes Trying to make the CLA bot happy with ppl from different companies work on one commit lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@vdemeester @dibyom @chmouel @abayer @tekton-robot @googlebot