Enhance reconcile of taskrun to avoid extra pod creation #2022
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Fix issue: #1976
The root cause for the issue is:
The
reconsile
oftaskrun
hit error:it's a benign error, we should just ignore it, but current reconcile cannot, see the logic:
taskrun.Status.Podname
is nil, if not, get the pod and move on, one follow-up step is addREADY
annotation to the pod to make pod run container one by one.taskrun.Status.Podname
is nil, create a new pod and move on.The problem is:
If hit
Failed to update taskRun status
error, thetaskrun
will stay in workqueue and reconcile again after increased delay, but thePodname
is still nil (although it's not in real world, since the pod has been created), so a extra pod will be created. and the previous pod will stick inRunning
forever since no one addREADY
annotation.Submitter Checklist
These are the criteria that every PR should meet, please check them off as you
review them:
See the contribution guide for more details.
Double check this list of stuff that's easy to miss:
cmd
dir, please updatethe release Task to build and release this image.
Reviewer Notes
If API changes are included, additive changes must be approved by at least two OWNERS and backwards incompatible changes must be approved by more than 50% of the OWNERS, and they must first be added in a backwards compatible way.
Release Notes