Update dind example to connect to daemon using TCP+TLS #1932
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some time after 18.09, Docker stopped communicating with its daemon using the socket, and instead uses TCP. This example now uses TCP accordingly, without TLS.
- share the path the daemon generates certs into with the client - instruct the client to look for certs there, and to use them - add a readinessProbe to wait for the certs to be generated
googlebot
added
the
cla: yes
tekton-robot
added
the
size/M
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: vdemeester The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
tekton-robot
added
the
approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some time after 18.09, Docker stopped communicating with its daemon
using the socket, and instead uses TCP. This example now uses TCP
accordingly, with TLS.
Submitter Checklist
These are the criteria that every PR should meet, please check them off as you
review them:
Fixes #1929
Supercedes #1928