Implement template variable expansion for Resources. #153
Conversation
knative-prow-robot
added
the
size/L
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dlorenc The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
knative-prow-robot
added
the
approved
This commit builds upon tektoncd#149 and makes resource keys available for expansion inside a TaskRun. Resources are available under the namespace 'inputs.resources', and each resource is namespaced under it's own name. This commit adds to the PipelineResourceInterface, requiring types to support a Replacements method. This supplies keys to be replaced.
dlorenc
force-pushed
the
resources
branch
4 times, most recently
from
5b45385 to
886af16
Compare
| b = b.DeepCopy() | ||
| f(b) | ||
| return b | ||
| } |
knative-prow-robot
added
do-not-merge/hold
|
also one more comment from me, the
was wondering if we can combine these two operations in one loop? we can also make this optimization in a later PR if you want to merge this in. |
- Move logic to a new file in resources pkg. - Switch to using a Getter from a Lister - Add separate tests for params and resources
Ah I thought I addressed this somewhere else. I prefer keeping the two loops separate (for readability and testability), but we could fetch the list of resources once and use that in the loops rather than going through the Lister each time. I'm not sure how big of a speedup that would be though, given that the Lister is cached. WDYT? |
Fixed it! |
| case PipelineResourceTypeImage: | ||
| return NewImageResource(r) | ||
| } | ||
| return nil, fmt.Errorf("%s is an invalid or unimplemented PipelineResource", r.Spec.Type) |
| } | ||
| } | ||
|
|
||
| type rg struct { |
|
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
im just gonna remove the hold for you cuz i assume that is what you want 😇 /hold cancel |
knative-prow-robot
removed
the
do-not-merge/hold
Fix typo in Makefile
This commit builds upon #149 and makes resource keys available for expansion
inside a TaskRun.
Resources are available under the namespace 'inputs.resources', and each
resource is namespaced under it's own name.
This commit adds to the PipelineResourceInterface, requiring types to support a
Replacements method. This supplies keys to be replaced.
Ref #64