Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adopt Kubernetes native Sidecar Containers #7617

Open
4 tasks
pritidesai opened this issue Jan 25, 2024 · 1 comment
Open
4 tasks

Adopt Kubernetes native Sidecar Containers #7617

pritidesai opened this issue Jan 25, 2024 · 1 comment
Labels
kind/feature Categorizes issue or PR as related to a new feature.

Comments

@pritidesai
Copy link
Member

pritidesai commented Jan 25, 2024

Tekton Pipelines v0.7 introduced the sidecar support in a task with #936 back in June 2019.

The sidecars are implemented in such a way that the users can specify a list of steps/containers running as sidecars. The entrypoint initializes sidecar containers and waits until they are ready to initiate the step containers. Once all the step containers are done, the entrypoint replaces the sidecar container image with nop to terminate the sidecars.

The existing sidecar implementation has been working great with some caveats. Kubernetes 1.29 introduced an in-built support for sidecar containers.

Tekton community had discussion to adopt Kubernetes native approach to sidecars during the API WG on 01/22/24. The community came to an agreement to continue supporting the custom sidecar implementation for backward compatibility purpose and for older version of Kubernetes. And at the same time, adopt Kubernetes native sidecar implementation for the users running compatible version of Kubernetes. We have identified a list of tasks as part of this effort:

  • Introduce a check for the Kubernetes version in the Tekton controller. As part of this task, we need to identify what is the best way to implement this check and when it is most reliable.
  • Adopt and implement Kubernetes sidecar container only for a compatible Kubernetes version.
  • Tekton Pipelines currently requires minimum of 1.25. Work on changing this minimum to 1.29 if possible after Kubernetes native sidecar container support is tested and validated for some time.
  • Once the minimum version is upgraded to 1.29, cleanup code to cleanup the code and delete the custom sidecar implementation.

#1131 documents the need for this feature. And, can be closed once this is implemented.

/kind feature

@pritidesai pritidesai added the kind/feature Categorizes issue or PR as related to a new feature. label Jan 25, 2024
@vdemeester
Copy link
Member

cc @abayer

kgcarr added a commit to kgcarr/pipeline that referenced this issue Jun 14, 2024
kgcarr added a commit to kgcarr/pipeline that referenced this issue Jun 14, 2024
kgcarr added a commit to kgcarr/pipeline that referenced this issue Jun 14, 2024
kgcarr pushed a commit to kgcarr/pipeline that referenced this issue Jun 17, 2024
kgcarr pushed a commit to kgcarr/pipeline that referenced this issue Jun 19, 2024
kgcarr pushed a commit to kgcarr/pipeline that referenced this issue Jun 21, 2024
kgcarr pushed a commit to kgcarr/pipeline that referenced this issue Jun 21, 2024
kgcarr added a commit to kgcarr/pipeline that referenced this issue Jul 10, 2024
kgcarr added a commit to kgcarr/pipeline that referenced this issue Jul 10, 2024
kgcarr added a commit to kgcarr/pipeline that referenced this issue Jul 11, 2024
kgcarr added a commit to kgcarr/pipeline that referenced this issue Jul 11, 2024
kgcarr added a commit to kgcarr/pipeline that referenced this issue Jul 11, 2024
kgcarr added a commit to kgcarr/pipeline that referenced this issue Jul 11, 2024
kgcarr added a commit to kgcarr/pipeline that referenced this issue Jul 12, 2024
kgcarr added a commit to kgcarr/pipeline that referenced this issue Jul 12, 2024
kgcarr added a commit to kgcarr/pipeline that referenced this issue Jul 12, 2024
kgcarr added a commit to kgcarr/pipeline that referenced this issue Jul 12, 2024
kgcarr added a commit to kgcarr/pipeline that referenced this issue Jul 12, 2024
kgcarr added a commit to kgcarr/pipeline that referenced this issue Jul 12, 2024
kgcarr added a commit to kgcarr/pipeline that referenced this issue Jul 13, 2024
kgcarr added a commit to kgcarr/pipeline that referenced this issue Jul 13, 2024
tekton-robot pushed a commit that referenced this issue Jul 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature Categorizes issue or PR as related to a new feature.
Projects
None yet
Development

No branches or pull requests

2 participants