Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New features to conform to the Per-feature Flag Struct #7285

Closed
Tracked by #7177
JeromeJu opened this issue Oct 25, 2023 · 0 comments · Fixed by #7633
Closed
Tracked by #7177

New features to conform to the Per-feature Flag Struct #7285

JeromeJu opened this issue Oct 25, 2023 · 0 comments · Fixed by #7633
Labels
kind/misc Categorizes issue or PR as a miscellaneuous one.

Comments

@JeromeJu
Copy link
Member

JeromeJu commented Oct 25, 2023 •
edited
Loading

At the moment, there has been a window between the implementation of TEP0138 with the new Per-feature flag struct and its proposal. During this period, there have been new features coming in that were not able to use the new Per-feature Flag struct. This issue tracks the patches that needs to be made for the existing new feature flags:

[update] now that TEP0138 and the per-feature flag implementation PR has been merged, we are introducing the CI tests for per feature flags. Pending decision to be made on Plumbing #1629
@tekton-robot tekton-robot added the kind/misc Categorizes issue or PR as a miscellaneuous one. label Oct 25, 2023
@JeromeJu JeromeJu mentioned this issue Oct 25, 2023
Merged
7 tasks
JeromeJu added a commit to JeromeJu/pipeline that referenced this issue Feb 5, 2024
@JeromeJu
TEP-0138 New features to use Per-feature flag struct
97d1893 
This commit uses the Per-feature flag struct for features added in
between the window that the changes per TEP0138 was made. All new
features should conform to the new Per-feature flag struct.

/kind misc
fixes: tektoncd#7285
@JeromeJu JeromeJu mentioned this issue Feb 5, 2024
Merged
7 tasks
tekton-robot pushed a commit that referenced this issue Feb 12, 2024
@JeromeJu @tekton-robot
TEP-0138 New features to use Per-feature flag struct
2c11092 
This commit uses the Per-feature flag struct for features added in
between the window that the changes per TEP0138 was made. All new
features should conform to the new Per-feature flag struct.

/kind misc
fixes: #7285
@JeromeJu JeromeJu mentioned this issue Feb 13, 2024
Closed
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
kind/misc Categorizes issue or PR as a miscellaneuous one.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

TEP-0138 New features to use Per-feature flag struct JeromeJu/pipeline
2 participants
@JeromeJu @tekton-robot