Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add cluster and clusterBindings to types #21

Closed
bobcatfish opened this issue Sep 8, 2018 · 1 comment
Closed

Add cluster and clusterBindings to types #21

bobcatfish opened this issue Sep 8, 2018 · 1 comment
Labels
good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines.

Comments

@bobcatfish
Copy link
Collaborator

Expected Behavior

The following types should be added:

(All should be optional)

This wouldn't be expected to actually do anything yet (similar to the rest of the current implementation).

Actual Behavior

We have references to clusters in our example tasks:

https://github.com/knative/build-pipeline/blob/3726a431cee21f9a88bc320339c978cca59a58e5/examples/deploy_tasks.yaml#L17-L18

Clusters defined in our example pipeline params:

https://github.com/knative/build-pipeline/blob/3726a431cee21f9a88bc320339c978cca59a58e5/examples/pipelineparams.yaml#L33-L39

Note that the clusterBinding example is incomplete:
https://github.com/knative/build-pipeline/blob/3726a431cee21f9a88bc320339c978cca59a58e5/examples/pipelines/kritis.yaml#L44-L45

This should be binding a cluster from PipelineParams to a cluster input in the Task, e.g.

          clusterBindings:
              -  inputName: clusterName # refers to the input in the Task
                 clusterName: test # refers to the cluster in the PipelineParms

Additional Info

@barney-s will be working on designs around deployment and k8s cluster interaction for this project

@bobcatfish bobcatfish added the help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. label Sep 8, 2018
@bobcatfish bobcatfish added the good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. label Sep 12, 2018
@shashwathi
Copy link
Contributor

/assign @shashwathi

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines.
Projects
None yet
Development

No branches or pull requests

2 participants