-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add workspace-like support for block devices #2057
Comments
/kind feature |
Discussed in beta working group, folks could continue to use podTemplates to accomplish this, even if we went ahead to remove Volumes in #2058, so this isn't a blocker for beta. |
... i did NOT mean to close this wow |
Hmm... after playing with the podTemplate technique one issue is that the definition is in the "taskrun" but the mounting is in the "task". Still a possible workaround but we really should add this support shortly. |
Stale issues rot after 30d of inactivity. /lifecycle rotten Send feedback to tektoncd/plumbing. |
Issues go stale after 90d of inactivity. /lifecycle stale Send feedback to tektoncd/plumbing. |
Interestingly we haven't had any further requests for this since opening the issue, so maybe closing it makes sense until someone really needs it. |
Stale issues rot after 30d of inactivity. /lifecycle rotten Send feedback to tektoncd/plumbing. |
If I can get our local provisioner to work as a block storage provider this might become relevant again. I do have use-cases that need block storage but the availability of a "cheap" provisioner is holding this back. |
I have a concrete use-case for this now. We use a ClusterTask to do image builds that "needs" to run with Block storage. I am doing this behind the scenes with volume and volumeDevices but would like to at least look at modelling in the Task definition as a workspace variation. |
Thanks @skaegi ! /remove-lifecycle rotten |
Issues go stale after 90d of inactivity. /lifecycle stale Send feedback to tektoncd/plumbing. |
Stale issues rot after 30d of inactivity. /lifecycle rotten Send feedback to tektoncd/plumbing. |
Rotten issues close after 30d of inactivity. /close Send feedback to tektoncd/plumbing. |
@tekton-robot: Closing this issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Expected Behavior
With workspaces, users can declare files they need at Task authoring time, and users can satisfy those requirements at run time with PVCs, emptyDirs, etc.
They should similarly be able to declare when a Task requires a block device, and provide the volume that satisfies this at runtime.
Actual Behavior
If a user wants to use block devices, they have to fall back on using volumes + volumeDevices in Tasks (e.g. similar to this example tho that example is using volumeMounts not volumeDevices). This mixes runtime information in at Task authoring time (the Task is declaring the name and the type of the Volume).
Additional Info
More info about raw block volumes at https://kubernetes.io/blog/2019/03/07/raw-block-volume-support-to-beta/
Taking the example "Using a raw block PVC" from this page, the interface could look like this:
@skaegi plz verify above ^^ :D
And speaking of @skaegi here is the version of this that he originally proposed: #1438 (comment)
The text was updated successfully, but these errors were encountered: