Add tests for system/names

pkg/system/names.go

@@ -29,5 +29,5 @@ func GetNamespace() string {
 	if systemNamespace == "" {
 		return DefaultNamespace
 	}
-	return os.Getenv(SystemNamespaceEnvVar)
+	return systemNamespace
 }

pkg/system/names_test.go

@@ -0,0 +1,35 @@
+package system
+
+import (
+	"os"
+	"testing"
+)
+
+func Test_GetNamespace(t *testing.T) {
+	testcases := []struct {
+		envVar       string
+		expectEnvVar string
+	}{
+		{
+			envVar:       "",
+			expectEnvVar: DefaultNamespace,
+		},
+		{
+			envVar:       "test",
+			expectEnvVar: "test",
+		},
+	}
+
+	value := os.Getenv(SystemNamespaceEnvVar)
+	defer func() { os.Setenv(SystemNamespaceEnvVar, value) }()
+
+	for _, ts := range testcases {
+		if err := os.Setenv(SystemNamespaceEnvVar, ts.envVar); err != nil {
+			t.Fatalf("Failed to set ENV: %v", err)
+		}
+
+		if got, want := GetNamespace(), ts.expectEnvVar; got != want {
+			t.Fatalf("Invalid namespace: got: %v, want: %v", got, want)
+		}
+	}
+}