Skip to content

Commit

Permalink
Fixes Steps container spec serialization/deserialization
Browse files Browse the repository at this point in the history
When using `Task/ClusterTask` API with dynamic client, serlization/deserialization
adds container as child key as Spec.steps[*].Container. Ideally, it should preserver
the step spec state and should not add the step spec details under the child
key container

This patch fixes the issue by adding right json directive in step
spec.

Fixes #2150
  • Loading branch information
hrishin authored and tekton-robot committed Mar 4, 2020
1 parent 06b5b04 commit 1203e8a
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion pkg/apis/pipeline/v1beta1/task_types.go
Original file line number Diff line number Diff line change
Expand Up @@ -103,7 +103,7 @@ type TaskResult struct {
// Step embeds the Container type, which allows it to include fields not
// provided by Container.
type Step struct {
corev1.Container
corev1.Container `json:",inline"`

// Script is the contents of an executable file to execute.
//
Expand Down

0 comments on commit 1203e8a

Please sign in to comment.