Skip to content

Commit

Permalink
Remove default namespace from samples 😅
Browse files Browse the repository at this point in the history
It feels really weird to try running the example on a different
namespace and not see them because the namespace is *hard-coded* in
the sample yaml.

Signed-off-by: Vincent Demeester <vdemeest@redhat.com>
  • Loading branch information
vdemeester authored and knative-prow-robot committed Dec 5, 2018
1 parent e5fe6eb commit 054702b
Show file tree
Hide file tree
Showing 9 changed files with 7 additions and 18 deletions.
3 changes: 1 addition & 2 deletions examples/build-task.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,6 @@ apiVersion: pipeline.knative.dev/v1alpha1
kind: Task
metadata:
name: build-push
namespace: default
spec:
inputs:
resources:
Expand All @@ -27,4 +26,4 @@ spec:
args:
- --dockerfile=${inputs.params.pathToDockerFile}
- --destination=${outputs.resources.builtImage.url}
- --context=${inputs.params.pathToContext}
- --context=${inputs.params.pathToContext}
2 changes: 1 addition & 1 deletion examples/default-cluster-admin.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -9,4 +9,4 @@ subjects:
roleRef:
kind: ClusterRole
name: cluster-admin
apiGroup: rbac.authorization.k8s.io
apiGroup: rbac.authorization.k8s.io
3 changes: 1 addition & 2 deletions examples/deploy-task.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,6 @@ apiVersion: pipeline.knative.dev/v1alpha1
kind: Task
metadata:
name: demo-deploy-kubectl
namespace: default
spec:
inputs:
resources:
Expand Down Expand Up @@ -37,4 +36,4 @@ spec:
args:
- 'apply'
- '-f'
- '${inputs.params.path}'
- '${inputs.params.path}'
3 changes: 1 addition & 2 deletions examples/output-pipeline.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,6 @@ apiVersion: pipeline.knative.dev/v1alpha1
kind: Pipeline
metadata:
name: output-pipeline
namespace: default
spec:
tasks:
- name: first-create-file # 1. create file
Expand All @@ -13,4 +12,4 @@ spec:
name: check-stuff-file-exists
resources:
- name: workspace
providedBy: [first-create-file]
providedBy: [first-create-file]
2 changes: 0 additions & 2 deletions examples/output-tasks.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,6 @@ apiVersion: pipeline.knative.dev/v1alpha1
kind: Task
metadata:
name: create-file
namespace: default
spec:
inputs:
resources:
Expand All @@ -28,7 +27,6 @@ apiVersion: pipeline.knative.dev/v1alpha1
kind: Task
metadata:
name: check-stuff-file-exists
namespace: default
spec:
inputs:
resources:
Expand Down
1 change: 0 additions & 1 deletion examples/pipeline.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,6 @@ apiVersion: pipeline.knative.dev/v1alpha1
kind: Pipeline
metadata:
name: demo-pipeline
namespace: default
spec:
tasks:
- name: build-skaffold-web
Expand Down
5 changes: 1 addition & 4 deletions examples/resources.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,6 @@ apiVersion: pipeline.knative.dev/v1alpha1
kind: PipelineResource
metadata:
name: skaffold-git
namespace: default
spec:
type: git
params:
Expand All @@ -15,7 +14,6 @@ apiVersion: pipeline.knative.dev/v1alpha1
kind: PipelineResource
metadata:
name: skaffold-image-leeroy-web
namespace: default
spec:
type: image
params:
Expand All @@ -26,9 +24,8 @@ apiVersion: pipeline.knative.dev/v1alpha1
kind: PipelineResource
metadata:
name: skaffold-image-leeroy-app
namespace: default
spec:
type: image
params:
- name: url
value: gcr.io/christiewilson-catfactory/leeroy-app
value: gcr.io/christiewilson-catfactory/leeroy-app
3 changes: 1 addition & 2 deletions examples/run/output-pipeline-run.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,6 @@ apiVersion: pipeline.knative.dev/v1alpha1
kind: PipelineRun
metadata:
name: output-pipeline-run
namespace: default
spec:
pipelineRef:
name: output-pipeline
Expand All @@ -26,4 +25,4 @@ spec:
inputs:
- name: workspace
resourceRef:
name: skaffold-git
name: skaffold-git
3 changes: 1 addition & 2 deletions examples/run/pipeline-run.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,6 @@ apiVersion: pipeline.knative.dev/v1alpha1
kind: PipelineRun
metadata:
name: demo-pipeline-run-1
namespace: default
spec:
pipelineRef:
name: demo-pipeline
Expand Down Expand Up @@ -46,4 +45,4 @@ spec:
name: skaffold-git
- name: image
resourceRef:
name: skaffold-image-leeroy-web
name: skaffold-image-leeroy-web

0 comments on commit 054702b

Please sign in to comment.