Skip to content
This repository has been archived by the owner on Dec 5, 2024. It is now read-only.

POC: Concurrency prototype with separate controller #895

Closed
wants to merge 2 commits into from

Conversation

lbernick
Copy link
Member

Changes

This commit adds a proof of concept for a controller that reconciles ConcurrencyControls, in order to control execution of concurrent PipelineRuns.

Submitter Checklist

These are the criteria that every PR should meet, please check them off as you
review them:

  • Includes docs (if user facing)
  • Commit messages follow commit message best practices
  • Commit messages includes a project tag in the subject - e.g. [OCI], [hub], [results], [task-loops]

See the contribution guide
for more details.

@tekton-robot
Copy link

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@tekton-robot tekton-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Sep 22, 2022
@tekton-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To complete the pull request process, please assign dibyom after the PR has been reviewed.
You can assign the PR to them by writing /assign @dibyom in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tekton-robot tekton-robot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Sep 22, 2022
This commit adds a proof of concept for a controller that reconciles
ConcurrencyControls, in order to control execution of concurrent PipelineRuns.
This commit adds a mutating admission webhook that patches all PRs with
pending status on creation, and updates the reconciler to start all pending PRs.
@lbernick
Copy link
Member Author

I've updated this POC to include an admission webhook that patches all PipelineRuns as pending on creation, and to have the reconciler start them on the first reconcile loop.

@tekton-robot
Copy link

@lbernick: PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@tekton-robot tekton-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Sep 27, 2022
@lbernick
Copy link
Member Author

lbernick commented Oct 3, 2022

Closing in favor of #905

@lbernick lbernick closed this Oct 3, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants