Skip to content
This repository has been archived by the owner on Dec 5, 2024. It is now read-only.

[notifiers/github] Add display name annotation. #779

Merged
merged 1 commit into from
Aug 10, 2021

Conversation

wlynch
Copy link
Member

@wlynch wlynch commented Aug 5, 2021

Changes

Adds an optional annotation to control what the statuses display name in
GitHub. If not specified, this defaults to the Task's name.

Submitter Checklist

These are the criteria that every PR should meet, please check them off as you
review them:

  • Includes docs (if user facing)
  • Commit messages follow commit message best practices
  • Commit messages includes a project tag in the subject - e.g. [OCI], [hub], [results], [task-loops]

See the contribution guide
for more details.

Fixes #779

Adds an optional annotation to control what the statuses display name in
GitHub. If not specified, this defaults to the Task's name.
@tekton-robot tekton-robot requested review from dibyom and a user August 5, 2021 15:32
@tekton-robot tekton-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Aug 5, 2021
@tekton-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sbwsg

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tekton-robot tekton-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 10, 2021
Copy link
Member

@dibyom dibyom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@tekton-robot tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Aug 10, 2021
@tekton-robot tekton-robot merged commit 2d51e9d into tektoncd:main Aug 10, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants