Skip to content
This repository has been archived by the owner on Dec 5, 2024. It is now read-only.

Using CronJobs to automatically clean up completed Runs #626

Merged
merged 1 commit into from
Oct 27, 2020

Conversation

psschwei
Copy link
Contributor

@psschwei psschwei commented Sep 2, 2020

Changes

This PR fixes #479 by providing documentation on how to use a CronJob to clean up old TaskRuns / PipelineRuns. It is based on what @afrittoli implemented in tektoncd/plumbing#442.

Submitter Checklist

These are the criteria that every PR should meet, please check them off as you
review them:

See the contribution guide
for more details.

@tekton-robot tekton-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Sep 2, 2020
Copy link
Member

@afrittoli afrittoli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this!
This looks good - the only missing bit is the cluster resource.
I think we can merge this as it is and then update it in a separate PR.

In fact it would be great to change this so that it does not use a pipeline resource anymore - since now they're deprecated. An alternative could be https://github.com/tektoncd/catalog/tree/master/task/kubeconfig-creator/0.1

/approve
/lgtm

@tekton-robot tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Oct 27, 2020
@psschwei
Copy link
Contributor Author

This looks good - the only missing bit is the cluster resource.
I think we can merge this as it is and then update it in a separate PR.

In fact it would be great to change this so that it does not use a pipeline resource anymore - since now they're deprecated.

Thanks @afrittoli -- will look to get those updates in later today / tomorrow

@tekton-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: afrittoli, vdemeester

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tekton-robot tekton-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 27, 2020
@tekton-robot tekton-robot merged commit 721e8c4 into tektoncd:master Oct 27, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Using CronJobs to automatically clean up completed Runs
4 participants