Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update E2E tests script to provide option for using nightly releases #2855

Merged
merged 1 commit into from
Apr 18, 2023
Merged

Update E2E tests script to provide option for using nightly releases #2855

merged 1 commit into from
Apr 18, 2023

Conversation

AlanGreene
Copy link
Member

@AlanGreene AlanGreene commented Apr 14, 2023 •
edited
Loading

Changes

Depends on #2854

Some automated tests just need to run the integration tests / browser
E2E tests against a specific release version. They do not need to
build the application from scratch.

Add support for an environment variable USE_NIGHTLY_RELEASE which
bypasses the normal npm install, webpack build, ko build, etc. and
instead deploys the latest nightly release to the target environment.

/kind misc

Submitter Checklist

As the author of this PR, please check off the items in this checklist:

  • Docs included if any changes are user facing
  • Tests included if any functionality added or changed
  • Follows the commit message standard
  • Meets the Tekton contributor standards (including
    functionality, content, code)
  • Has a kind label. You can add one by adding a comment on this PR that contains /kind <type>. Valid types are bug, cleanup, design, documentation, feature, flake, misc, question, tep
  • Release notes block below has been updated with any user facing changes (new features, significant UI changes, API changes, bug fixes, changes requiring upgrade notices or deprecation warnings)
  • Release notes contains the string "action required" if the change requires additional action from users switching to the new release

Release Notes

NONE

@tekton-robot tekton-robot added the kind/misc Categorizes issue or PR as a miscellaneuous one. label Apr 14, 2023
@tekton-robot tekton-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Apr 14, 2023
@tekton-robot tekton-robot requested a review from LyndseyBu April 14, 2023 15:26
@AlanGreene
Copy link
Member Author

/hold

@tekton-robot tekton-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 14, 2023
@AlanGreene AlanGreene force-pushed the e2e_improvements_nightly_release branch from 4a08b1a to a9e0388 Compare April 14, 2023 15:49
@AlanGreene
Copy link
Member Author

Cuts time for the integration tests down from 15-16 mins to about 8 mins on prow. Expect to see similar impact for the nightly tests on Z and P on dogfooding.

We'll make further improvements to this by building the E2E docker image as part of the nightly release (tagging with the same version) so we can use a prebuilt image in those tests.

briangleeson
briangleeson approved these changes Apr 17, 2023
View reviewed changes
Copy link
Contributor

@briangleeson briangleeson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@tekton-robot tekton-robot added lgtm Indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Apr 17, 2023
@AlanGreene
Update E2E tests script to provide option for using nightly releases
7f8887b 
Some automated tests just need to run the integration tests / browser
E2E tests against a specific release version. They do not need to
build the application from scratch.

Add support for an environment variable `USE_NIGHTLY_RELEASE` which
bypasses the normal `npm install`, webpack build, ko build, etc. and
instead deploys the latest nightly release to the target environment.
@AlanGreene AlanGreene force-pushed the e2e_improvements_nightly_release branch from a9e0388 to 2d9b471 Compare April 17, 2023 09:26
@tekton-robot tekton-robot removed the lgtm Indicates that a PR is ready to be merged. label Apr 17, 2023
briangleeson
briangleeson approved these changes Apr 17, 2023
View reviewed changes
Copy link
Contributor

@briangleeson briangleeson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@tekton-robot tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Apr 17, 2023
@AlanGreene AlanGreene force-pushed the e2e_improvements_nightly_release branch from 2d9b471 to 7f8887b Compare April 17, 2023 12:13
@tekton-robot tekton-robot removed the lgtm Indicates that a PR is ready to be merged. label Apr 17, 2023
@AlanGreene
Copy link
Member Author

AlanGreene commented Apr 17, 2023 •
edited
Loading

Finished testing, removing the temporary env change so we continue using the build from main in integration tests. The USE_NIGHTLY_RELEASE variable will only be used in nightly tests on dogfooding for now.
/hold cancel

@tekton-robot tekton-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 17, 2023
@AlanGreene AlanGreene mentioned this pull request Apr 17, 2023
Merged
2 tasks
briangleeson
briangleeson approved these changes Apr 18, 2023
View reviewed changes
Copy link
Contributor

@briangleeson briangleeson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@tekton-robot tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Apr 18, 2023
@tekton-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: briangleeson

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tekton-robot tekton-robot merged commit 4ed004f into tektoncd:main Apr 18, 2023
@AlanGreene AlanGreene deleted the e2e_improvements_nightly_release branch April 18, 2023 08:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@briangleeson briangleeson briangleeson approved these changes

@LyndseyBu LyndseyBu Awaiting requested review from LyndseyBu

Assignees

@briangleeson briangleeson

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/misc Categorizes issue or PR as a miscellaneuous one. lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@AlanGreene @tekton-robot @briangleeson