Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initial import of graph POC components #2783

Merged
merged 1 commit into from
Mar 6, 2023
Merged

Conversation

AlanGreene
Copy link
Member

Changes

Related to #675

Import base components and add required dependencies from the graph POC developed at https://codesandbox.io/s/54h4e

There are a number of TODO items in this code as well as config that needs to be properly tested and cleaned up, but this serves as a starting point for building out the real components, utils, and graph view for the Dashboard.

/kind misc

Submitter Checklist

As the author of this PR, please check off the items in this checklist:

  • Docs included if any changes are user facing
  • Tests included if any functionality added or changed
  • Follows the commit message standard
  • Meets the Tekton contributor standards (including
    functionality, content, code)
  • Has a kind label. You can add one by adding a comment on this PR that contains /kind <type>. Valid types are bug, cleanup, design, documentation, feature, flake, misc, question, tep
  • Release notes block below has been updated with any user facing changes (new features, significant UI changes, API changes, bug fixes, changes requiring upgrade notices or deprecation warnings)
  • Release notes contains the string "action required" if the change requires additional action from users switching to the new release

Release Notes

NONE

Import base components and add required dependencies from the graph POC.

There are a number of TODO items in this code as well as config that
needs to be properly tested and cleaned up, but this serves as a
starting point for building out the real components, utils, and
graph view for the Dashboard.
@tekton-robot
Copy link
Contributor

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@tekton-robot tekton-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. kind/misc Categorizes issue or PR as a miscellaneuous one. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Mar 5, 2023
@tekton-robot tekton-robot requested review from LyndseyBu and skaegi March 5, 2023 20:44
@AlanGreene AlanGreene requested review from briangleeson and removed request for skaegi March 6, 2023 16:42
@AlanGreene AlanGreene marked this pull request as ready for review March 6, 2023 16:42
@tekton-robot tekton-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Mar 6, 2023
@tekton-robot tekton-robot requested a review from skaegi March 6, 2023 16:42
@AlanGreene AlanGreene removed the request for review from skaegi March 6, 2023 16:42
Copy link
Contributor

@briangleeson briangleeson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One question, otherwise looks intriguing

.storybook/main.js Show resolved Hide resolved
Copy link
Contributor

@briangleeson briangleeson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@tekton-robot tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Mar 6, 2023
@tekton-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: briangleeson

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tekton-robot tekton-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 6, 2023
@tekton-robot tekton-robot merged commit 5eac28a into tektoncd:main Mar 6, 2023
@AlanGreene AlanGreene deleted the graph branch March 6, 2023 17:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/misc Categorizes issue or PR as a miscellaneuous one. lgtm Indicates that a PR is ready to be merged. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants