Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update container security context to satisfy PSA restricted requirements #2553

Merged
merged 1 commit into from
Oct 27, 2022

Conversation

AlanGreene
Copy link
Member

@AlanGreene AlanGreene commented Oct 27, 2022

Changes

#2552

Remove the PodSecurityContext and replace with container SecurityContext containing all the fields required to satisfy the new Pod Security Admission level 'restricted' which will be applied to the tekton-pipelines namespace by Pipelines v0.41. Without this the Dashboard pod fails to be scheduled on Kubernetes 1.23+ (or 1.22 with the alpha feature flag enabled) when that configuration is in place.

/kind misc

Submitter Checklist

As the author of this PR, please check off the items in this checklist:

  • Docs included if any changes are user facing
  • Tests included if any functionality added or changed
  • Follows the commit message standard
  • Meets the Tekton contributor standards (including
    functionality, content, code)
  • Has a kind label. You can add one by adding a comment on this PR that contains /kind <type>. Valid types are bug, cleanup, design, documentation, feature, flake, misc, question, tep
  • Release notes block below has been updated with any user facing changes (new features, significant UI changes, API changes, bug fixes, changes requiring upgrade notices or deprecation warnings)
  • Release notes contains the string "action required" if the change requires additional action from users switching to the new release

Release Notes

Action required: If using Kubernetes 1.22, set PodSecurity flag to true to enforce a restricted pod security level in Tekton namespaces. See https://kubernetes.io/docs/reference/command-line-tools-reference/feature-gates/#feature-gates-for-graduated-or-deprecated-features for more information.

Remove the PodSecurityContext and replace with container SecurityContext
containing all the fields required to satisfy the new Pod Security Admission
level 'restricted' which will be applied to the `tekton-pipelines` namespace
by Pipelines v0.41. Without this the Dashboard pod fails to be scheduled
on Kubernetes 1.23+ (or 1.22 with the alpha feature flag enabled) when that
configuration is in place.
@tekton-robot tekton-robot added kind/misc Categorizes issue or PR as a miscellaneuous one. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Oct 27, 2022
@AlanGreene AlanGreene removed the request for review from skaegi October 27, 2022 13:42
@AlanGreene AlanGreene added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Oct 27, 2022
@tekton-robot tekton-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Oct 27, 2022
Copy link
Contributor

@briangleeson briangleeson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@tekton-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: briangleeson

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tekton-robot tekton-robot added lgtm Indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Oct 27, 2022
@tekton-robot tekton-robot merged commit ca927d9 into tektoncd:main Oct 27, 2022
@AlanGreene
Copy link
Member Author

Cheeky robot, not sure why it removed the label…

image

No harm really, I was just holding off until I had doc + walk-through updates ready too. I'll follow up with those later.

@AlanGreene AlanGreene deleted the psa branch October 27, 2022 15:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/misc Categorizes issue or PR as a miscellaneuous one. lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants