Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update browser compatibility data #2278

Merged
merged 1 commit into from
Jan 13, 2022
Merged

Conversation

AlanGreene
Copy link
Member

Changes

Update browserslist/caniuse-lite to ensure we're using current browser
compatibility data. This prevents us from unnecessarily including
polyfills for features that are natively supported in newer browsers.

Reduce vendor bundle size by ~100K:

  • ~42K by updating caniuse-lite npx browserslist@latest --update-db
  • ~57K by removing relativetimeformat polyfill since it was only
    required for Safari 13 or older. Current supported versions are 14 and 15

Submitter Checklist

These are the criteria that every PR should meet, please check them off as you
review them:

See the contribution guide
for more details.

Update browserslist/caniuse-lite to ensure we're using current browser
compatibility data. This prevents us from unnecessarily including
polyfills for features that are natively supported in newer browsers.

Reduce vendor bundle size by ~100K:
- ~42K by updating caniuse-lite `npx browserslist@latest --update-db`
- ~57K by removing relativetimeformat polyfill since it was only
  required for Safari 13 or older. Current supported versions are 14 and 15
@tekton-robot tekton-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jan 12, 2022
@AlanGreene AlanGreene removed the request for review from skaegi January 12, 2022 13:32
Copy link
Contributor

@briangleeson briangleeson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@tekton-robot tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Jan 13, 2022
@tekton-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: briangleeson

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tekton-robot tekton-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 13, 2022
@tekton-robot tekton-robot merged commit 5bca777 into tektoncd:main Jan 13, 2022
@AlanGreene AlanGreene deleted the browsers branch January 13, 2022 12:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants