Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add khrm, sayan and enarha to Results Maintainers #975

Merged
merged 1 commit into from
Apr 18, 2023

Conversation

khrm
Copy link
Contributor

@khrm khrm commented Mar 8, 2023

I am doing the release, so I need to be a member of the maintainers team in results. I need access to release notes. Same with other members, they will probably do the release in future.

I am doing the release, so I need to be members of maintainers
team in results. I need access to release notes. Same with other
members, they will probably do the release in future.
@tekton-robot tekton-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Mar 8, 2023
@khrm
Copy link
Contributor Author

khrm commented Mar 8, 2023

/assign @adambkaplan @alan-ghelardi

@tekton-robot
Copy link
Contributor

@khrm: GitHub didn't allow me to assign the following users: adambkaplan, alan-ghelardi.

Note that only tektoncd members, repo collaborators and people who have commented on this issue/PR can be assigned. Additionally, issues/PRs can only have 10 assignees at the same time.
For more information please see the contributor guide

In response to this:

/assign @adambkaplan @alan-ghelardi

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@dibyom
Copy link
Member

dibyom commented Mar 8, 2023

/cc @adambkaplan @alan-ghelardi

@tekton-robot
Copy link
Contributor

@dibyom: GitHub didn't allow me to request PR reviews from the following users: adambkaplan, alan-ghelardi.

Note that only tektoncd members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to this:

/cc @adambkaplan @alan-ghelardi

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@alan-ghelardi
Copy link
Contributor

🎉
/approve

@adambkaplan
Copy link
Contributor

/lgtm

@tekton-robot
Copy link
Contributor

@adambkaplan: changing LGTM is restricted to collaborators

In response to this:

/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@adambkaplan
Copy link
Contributor

/assign @vdemeester

Looks good - khrm and sayan are both at > 100 points on devstats.

@enarha
Copy link

enarha commented Apr 17, 2023

I volunteered for doing the v0.6.0 release of Tekton Results, but without that PR being merged, I do not have permissions to actually do it.

@adambkaplan
Copy link
Contributor

bump @tektoncd/community-collaborators @tektoncd/community-maintainers

Copy link
Member

@vdemeester vdemeester left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@adambkaplan the OWNER file on tektoncd/results reflects that changes ?

@tekton-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: alan-ghelardi, vdemeester

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tekton-robot tekton-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 17, 2023
@enarha
Copy link

enarha commented Apr 17, 2023

@adambkaplan the OWNER file on tektoncd/results reflects that changes ?

It does not. I'll create a PR to update it. [EDIT] tektoncd/results#435

@lbernick
Copy link
Member

/lgtm

@tekton-robot tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Apr 18, 2023
@tekton-robot tekton-robot merged commit 8f8d17d into tektoncd:main Apr 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants