TEP-0090: Matrix - Minimal Status is Required #736
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Prior to this change, we had agreed that the minimal status would be auto-added for PipelineTasks which have a Matrix. During the implementation, realized that it's unclear how we should handle the other PipelineTasks in the Pipeline that don't have a Matrix. Also realized that the automagic is opaque to users and could be surprising to users who're not aware of the ChildReferences. In this change, we propose that users have to enable the minimal status to use Matrix. This is not a restrictive requirement as is the direction we're moving to, and will become the default soon. More importantly, it makes the behavior clear and the improves the user experience.
tekton-robot
added
the
kind/tep
tekton-robot
added
the
size/S
|
related PR: #725 |
tekton-robot
added
the
approved
|
/approve |
5 tasks
vdemeester
approved these changes
Jun 23, 2022
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: abayer, dibyom, vdemeester The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/assign @vdemeester |
|
@abayer @dibyom @vdemeester can we please merge this offline? |
|
/lgtm |
jerop
added a commit
to jerop/pipeline
that referenced
this pull request
Jun 24, 2022
In tektoncd/community#736, we decided that `Matrix` will use `ChildReferences` only. Therefore, it is unnecessary to check the `TaskRuns` field of `PipelineRun` status when getting the names of `TaskRuns` for matrixed `PipelineTasks`. Related PR: tektoncd#5019
jerop
added a commit
to jerop/pipeline
that referenced
this pull request
Jun 24, 2022
In tektoncd/community#736, we decided that `Matrix` will use `ChildReferences` only. Therefore, it is unnecessary to check the `TaskRuns` field of `PipelineRun` status when getting the names of `TaskRuns` for matrixed `PipelineTasks`. Related PR: tektoncd#5019
4 tasks
tekton-robot
pushed a commit
to tektoncd/pipeline
that referenced
this pull request
Jun 24, 2022
In tektoncd/community#736, we decided that `Matrix` will use `ChildReferences` only. Therefore, it is unnecessary to check the `TaskRuns` field of `PipelineRun` status when getting the names of `TaskRuns` for matrixed `PipelineTasks`. Related PR: #5019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prior to this change, we had agreed that the minimal status would
be auto-added for PipelineTasks which have a Matrix. During the
implementation, realized that it's unclear how we should handle
the other PipelineTasks in the Pipeline that don't have a Matrix.
Also realized that the automagic is opaque to users and could be
surprising to users who're not aware of the ChildReferences.
In this change, we propose that users have to enable the minimal
status to use Matrix. This is not a restrictive requirement as is
the direction we're moving to, and will become the default soon.
More importantly, it makes the behavior clear and the improves the
user experience.
/kind tep
cc @abayer