Skip to content

Commit

Permalink
Update TEP-0086 with PVC/workspace result passing POC
Browse files Browse the repository at this point in the history
  • Loading branch information
Tomcli authored and tekton-robot committed Dec 1, 2022
1 parent 7f988ae commit ac38f17
Showing 1 changed file with 32 additions and 1 deletion.
33 changes: 32 additions & 1 deletion teps/0086-changing-the-way-result-parameters-are-stored.md
Original file line number Diff line number Diff line change
Expand Up @@ -354,6 +354,23 @@ tasks:
- name: in
value: "$(tasks.first-task.results.out)"
```
Alternatively, the remote storage flag can be specified as a new field. e.g.
```yaml
tasks:
- name: first-task
taskSpec: foo
results:
- name: out
type: string
storage: reference # <-- *new type*
- name: second-task
taskSpec: bar
params:
- name: in
value: "$(tasks.first-task.results.out)"
```
```yaml
apiVersion: tekton.dev/v1beta1
Expand Down Expand Up @@ -426,6 +443,20 @@ Questions:
file contents in the PVCs and replace the pvc/storage path with the new contents. This can avoid the 1.5 MB CRD size as the result contents are
replaced during init-container, so it won't be part of the pod or taskrun spec. In the API Spec, we could let users to choose whether to opt-in this
feature for each task to reduce the unnecessary overheads if not needed.

#### API details:
- In the Pipeline API field, introduce a new field `resultWorkspace` for passing all the `reference` type results. The new field consist the name of the workspace name for passing the big results and can extend in the future for more workspace configurations.


```yaml
apiVersion: tekton.dev/v1beta1
kind: Pipeline
spec:
resultWorkspace:
name: shared-data
...
```
- POC pull request: [TEP-0086 Large results using workspace POC](https://github.com/tektoncd/pipeline/pull/5337)

Pros:
- PVCs can leverage with CSI driver to store files in most storages.
Expand Down Expand Up @@ -514,7 +545,7 @@ Note: This section is exclusively for merged pull requests, for this TEP.
It will be a quick reference for those looking for implementation of this TEP.
-->

- [TEP-0086 remote storage result POC](https://github.com/tektoncd/pipeline/pull/4838)
- [TEP-0086 Large results using workspace POC](https://github.com/tektoncd/pipeline/pull/5337)

## Next steps to unblock

Expand Down

0 comments on commit ac38f17

Please sign in to comment.