Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incoherencies between tkn pipeline ls and tkn task ls #596

Closed
chmouel opened this issue Jan 13, 2020 · 8 comments
Closed

Incoherencies between tkn pipeline ls and tkn task ls #596

chmouel opened this issue Jan 13, 2020 · 8 comments
Labels
good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt.

Comments

@chmouel
Copy link
Member

chmouel commented Jan 13, 2020

If we do a tkn pipeline ls we have the start, duration and status field.

image

while if we do a tkn task ls we only have an age :

image

It could be nice to homogenize this

@chmouel chmouel added the good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. label Jan 13, 2020
@chmouel
Copy link
Member Author

chmouel commented Jan 13, 2020

/kind feature

@tekton-robot tekton-robot added the kind/feature Categorizes issue or PR as related to a new feature. label Jan 13, 2020
@chmouel chmouel added kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. and removed kind/feature Categorizes issue or PR as related to a new feature. labels Jan 13, 2020
@danielhelfand
Copy link
Member

/assign

@vdemeester
Copy link
Member

This was the initial decision, to not have latest TaskRun execution on tasks. A Task can be executed in a lot of ways, in a lot of different Pipeline (or on its own), and it didn't really make sense to display the "latest" one, as.. there is no context to it.

@chmouel
Copy link
Member Author

chmouel commented Jan 21, 2020

yes but we can show the satus?

@vdemeester
Copy link
Member

yes but we can show the satus?

Which status ? We can display the status of the last run of this Task, yeah, but what is the value for this ? What if the task is ran in 50 different pipeline with complete different parameter ?

Let's take the go-build task, it is highly generic. Let's assume I have 10 pipeline that build go project in my namespace, and thus I use this task on all of them at some point (but with different parameter, as the package, and maybe some options will differ). What value does it add to display the latest run status of this ?

Also, if I have 5 pipeline running at the same time, and this task running 3 times in parallel, which one do I display ? what value does it add there too ?

It's a bit simple for Pipeline and the latest pipelinerun as a Pipeline sands on its own. The failure of a pipeline (or the success) mean something on its own. For most cases, the failure of a Task doesn't mean much outside of the Pipeline context.

@danielhelfand
Copy link
Member

danielhelfand commented Jan 21, 2020

This was the initial decision, to not have latest TaskRun execution on tasks. A Task can be executed in a lot of ways, in a lot of different Pipeline (or on its own), and it didn't really make sense to display the "latest" one, as.. there is no context to it.

Can see the thought on why this was left out. I was going to make the argument that tasks are namespaced being a factor in why this makes sense (so it would be limited in terms of what it carries out), but I could see a use where multiple pipelines use the same task in a namespace. Not sure where the discussion is with referencing tasks from other namespaces, but that would further complicate this.

I think an interesting thought would be whether this applies to ClusterTasks, but It seems like there is some momentum for ClusterPipelines.

So while on the surface this looked like a good idea, I am having some second thoughts.

@danielhelfand danielhelfand removed their assignment Mar 23, 2020
@chmouel
Copy link
Member Author

chmouel commented Apr 21, 2020

/close

@tekton-robot
Copy link
Contributor

@chmouel: Closing this issue.

In response to this:

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt.
Projects
None yet
Development

No branches or pull requests

4 participants