-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add option for role management per database #120
base: main
Are you sure you want to change the base?
Conversation
I would keep this optional as there are good chances that there is only 1 DB instance. Also, rather than using EXECUTE, I would opt for parameters called from psql, similarly to what we do with SRID. |
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I pass this on to @ponceta
This comment was marked as resolved.
This comment was marked as resolved.
Are there any adaptations required since we will drop and recreate tww_app schema on a regular basis? |
I will add a script to create_app.py to re-create the grants if the role exists |
I now added a Plugin menu item to create database roles. It is only active if the admin mode is enabled and checks for superuser rights before doing anything Edit: Going via the plugin does not work as we can't find the corresponding pg_service without having the database set up |
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
@ponceta Is this ready for 2024.0 and can be merged? |
This will remove the SQL script with pgAdmin for rights management, I think wait for 2024.1 or 2025.0 is the best way to go. This is strongly linked to TMMT. (Same as #399) |
General
Describe your changes
TODO : Adapt changes definition as it now provides a structure for database, module and role naming and roles management.
In addition to the generic users
tww_viewer
,tww_user
,tww_manager
,tww_sysadmin
, this PR creates database-specific pendants for cases such as QGEP/QGEP#840Screenshots
Issue ticket number and link
Checklist before requesting a review
Checklist before merge