add test for tww_sys tables #119
Conversation
3nids
force-pushed
the
test-sys-tables
branch
from
3cab083 to
306a805
Compare
|
@sjib in |
@domi4484 Should be solved now in #110 with a95560d
|
@3nids Here I have to create two additional tww_dictionary_ files that corresponds to
|
|
Extra issue added: #134 |
|
(once this is merged, I'll add a test for the attributes) |
- [x] not adddataowner and provider in dictionary table in _text - as not existing in datamodel - [x] delete dataowner and provider in dictionary table in _text - as not existing in datamodel - [x] rename tablename in dictionary field to re_* - else linking not working - [x] check attributes geometry - see #119 (comment) - [ ] check entries for extra_tables _* (currently _planning_zone and _aquifier) - see #119 (comment) - Moved to extra issue #134 and pull request (to be defined) - [x] adding reach_progression_alternative to dictionary tables in tww_sys - [x] adding wastwater_structure_text, reach_text, catchment_text to dictionary tables in tww_sys
…lternative) (#151) * various fixes [x] add DEFERRABLE INITIALLY DEFERRED also to re_table tww_od.re_building_group_disposal [x] delete txt_symbol [x] delete txt_text [x] delete progression_alternative - replace by reach_progression_alternative [x] fk_operating_company DEFERRABLE [x] wx class shortcut adde for wastewater_structure_text [x] rx class shortcut adde for reach_text [x] cx class shortcut adde for catchment_area_text [x] bx class shortcut adde for wastewater_structure_symbol [x] reach_progression_alternative.fk_reach added * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * fixes 09_tww_dictionaries - [x] not adddataowner and provider in dictionary table in _text - as not existing in datamodel - [x] delete dataowner and provider in dictionary table in _text - as not existing in datamodel - [x] rename tablename in dictionary field to re_* - else linking not working - [x] check attributes geometry - see #119 (comment) - [ ] check entries for extra_tables _* (currently _planning_zone and _aquifier) - see #119 (comment) - Moved to extra issue #134 and pull request (to be defined) - [x] adding reach_progression_alternative to dictionary tables in tww_sys - [x] adding wastwater_structure_text, reach_text, catchment_text to dictionary tables in tww_sys * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci --------- Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
|
Datamodel test should now only fail on import and network classes |
|
E AssertionError: Lists differ: ['network_node', 'import_manhole_quarantine', 'network_segment'] != [] datamodel/test/test_sys.py:45: AssertionError Fails successfully! :) |
Fix import
for more information, see https://pre-commit.ci
Add extra od tables
for more information, see https://pre-commit.ci
|
@ponceta When should we integrate this 2024.1? |
we have tables in the od schema which are not listed in tww_sys.dictionnary_od_table:
reach_text => ?
wastewater_structure_text => ?
catchment_area_text => ?
reach_progression_alternative => ?
_planning_zone => ?
_aquifier => ?
wastewater_structure_symbol => ?
import_manhole_quarantine => should be skipped
network_node => should be skipped
network_segment => should be skipped
@sjib can you add the missing tables or explain what to do?