Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add file and data_media classes to the datamodel, create vw_file #59

Merged
merged 13 commits into from
Jan 7, 2025

Conversation

ponceta
Copy link
Member

@ponceta ponceta commented Oct 25, 2024

General

  • Fix a bug
  • Add a feature
  • Maintenance / sustainability
  • Add Documentation

Describe your changes

Handle document management in TEKSI district heating

  • Proposition is to add same classes as for TEKSI wastewater (file and data_media) (multi document management #51)
  • Brings many aditionnal fixes on the application schema evolution (replicate this logic to TDH for consistency #56)
  • QGIS project adaption - add new layer based on vw_file and create form for it. Discuss usability and needs of user. Check on tww how it is implemented and standardize
  • Add documentation to Developers guide how to integrate these two classes in any module

Screenshots

Issue ticket number and link

Checklist before requesting a review

  • I have performed a self-review of my code
  • If it is a core feature, I have added thorough tests.
  • CI Tests are green
  • The documentation is up to date with the proposed change.
  • My work is ready for review

Checklist before merge

  • A review has been performed
  • Comments are resolved
  • Documentation is ready

To handle document management in TEKSI district heating
@ponceta ponceta added enhancement New feature or request datamodel labels Oct 25, 2024
ponceta and others added 9 commits October 25, 2024 08:52
Fix setup
Move functions where they belong
Move calls to tdh_sys.generate_oid to tdh_app.generate_oid
Move triggers and defaults to app as for TWW
Add modification_last_modified functions
Remove duplicated triggers
@ponceta ponceta self-assigned this Oct 25, 2024
@ponceta ponceta requested a review from sjib October 25, 2024 07:59
@ponceta
Copy link
Member Author

ponceta commented Oct 25, 2024

Requesting @sjib on the datamodel part (wise to base on such a part of a model / dangerous?)

@sjib
Copy link
Contributor

sjib commented Oct 28, 2024

Requesting @sjib on the datamodel part (wise to base on such a part of a model / dangerous?)

As these are two indepentand classes that are linke only to each other I think we can use them also in tdh. We could easily write an INTERLIS model file with just these two classes if we ever would need to transfer them. The matching logic and settings could be copied from VSA-KEK Import / Export in TWW.

What would be the other option?

  • Create something new on our own? -> I don't think that would be better
  • ...

@sjib
Copy link
Contributor

sjib commented Oct 28, 2024

@ponceta I listed the complete list of triggers and functions that should be added in this issue: #60

Copy link
Contributor

@sjib sjib left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

see comments above

@sjib
Copy link
Contributor

sjib commented Oct 28, 2024

Should solve #60 when finished

@sjib
Copy link
Contributor

sjib commented Oct 28, 2024

@ponceta I think meta_functions should also be added.
symbology_functions I think would also make sense - here we then would have to document the logic and name the symbology_triggers accordingly.

@sjib
Copy link
Contributor

sjib commented Oct 28, 2024

@ponceta First integrate #61 before pushing this

@ponceta
Copy link
Member Author

ponceta commented Nov 5, 2024

Waiting for #61 then ;)

@ponceta ponceta closed this Nov 28, 2024
@ponceta ponceta reopened this Nov 28, 2024
@ponceta ponceta merged commit db08737 into main Jan 7, 2025
9 checks passed
@ponceta ponceta deleted the poa_add_file_and_data_media branch January 7, 2025 15:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants