🚀 #1
Merged
🚀 #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
.eleventy.js
Outdated
Comment on lines
11
to
16
| var payload = { | ||
| "title": radar.category, | ||
| "date": radar.date, | ||
| ...baseSettings, | ||
| ...radar.data | ||
| }; |
There was a problem hiding this comment.
- используй пожалуйста const а не var
- деструктуризация baseSettings и radar.data может затереть то что ты выше подметил для title и date, поэтому лучше так попробуй:
const payload = { ...baseSettings, ...radar.data, title: radar.category, date: radar.date, };
src/_collections/radars.js
Outdated
| const { parse } = require("csv-parse/sync"); | ||
|
|
||
| function readCSV(dir) { | ||
| var file = fs.readFileSync(dir); |
src/_collections/radars.js
Outdated
| const rings = Object.keys(settings.rings).map((e) => settings.rings[e]); | ||
| const quadrants = Object.keys(settings.quadrants.names).map((e) => ({ name: settings.quadrants.names[e] })); | ||
|
|
||
| var entries = []; |
There was a problem hiding this comment.
src/_collections/radars.js
Outdated
| const radarsDir = path.join(process.cwd(), "radars") | ||
| const categories = fs.readdirSync(radarsDir) | ||
|
|
||
| var radars = []; |
There was a problem hiding this comment.
src/_collections/radars.js
Outdated
Comment on lines
62
to
65
| var categoryPath = path.join(radarsDir, category); | ||
|
|
||
| var settingsPath = path.join(categoryPath, "settings.json"); | ||
| var settings = {}; |
There was a problem hiding this comment.
src/_collections/radars.js
Outdated
Comment on lines
67
to
69
| if (fs.existsSync(settingsPath)) { | ||
| settings = JSON.parse(fs.readFileSync(settingsPath), 'utf8'); | ||
| } |
There was a problem hiding this comment.
const settings = fs.existsSync(settingsPath) ? JSON.parse(fs.readFileSync(settingsPath), 'utf8') : {}
|
LGTM! |
temirlan-tekmates
approved these changes
Aug 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The initial implementation of technology radar