Assign a data path and serial number to each test in discover #1876
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
happz
force-pushed
the
test-assign-serial-and-data-path
branch
from
d7a8c5c
to
e49d0ad
Compare
|
Hm, when the test name is |
Yeah, I'm adding some tests, I'll add this case as well. No idea how it happens though, but I'll look into it. |
happz
added
step | execute
happz
force-pushed
the
test-assign-serial-and-data-path
branch
from
e49d0ad
to
98dd070
Compare
thrix
requested changes
Feb 28, 2023
lukaszachy
reviewed
Feb 28, 2023
|
Fails in tests/full: All failed with test assuming the old path |
To support both multihost scenarios and/or running a test multiple times, tmt needs to distinguish test data directories of different test instances. To allow this, each test instance is given a "serial number" which we can use in a data directory name. Note: there can be more elaborate ways for picking the serial numbers, the patch starts with something really trivial yet functioning. Another note: the patch does not isolate tests on a phase level, a single test, executed on different guests, may still land in the same data directory. Different patch will solve this issue.
happz
force-pushed
the
test-assign-serial-and-data-path
branch
2 times, most recently
from
8ec2aca
to
359930d
Compare
happz
force-pushed
the
test-assign-serial-and-data-path
branch
from
359930d
to
142b5c3
Compare
|
Tests are green \o/ So, looking for reviews & merge, then:
|
janhavlin
approved these changes
Mar 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To support both multihost scenarios and/or running a test multiple times, tmt needs to distinguish test data directories of different test instances. To allow this, each test instance is given a "serial number" which we can use in a data directory name.
Note: there can be more elaborate ways for picking the serial numbers, the patch starts with something really trivial yet functioning.
Another note: the patch does not isolate tests on a phase level, a single test, executed on different guests, may still land in the same data directory. Different patch will solve this issue.
Part of the effort in #1614 and #1790.