This repository has been archived by the owner on Oct 16, 2022. It is now read-only.
Check mount points for existing snapshot directory #537
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… bind mount points
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This proposed fix could fix issues #83, #227, #535, and maybe #536; where bind mounts cause Timeshift to use a different directory.
In
unlock_and_mount_devicefunction when there are multiple mount points for a device; loop through each mount point and check if there is already a snapshot directory (<mount_point>/timeshift/snapshots). If the directory exists then use that mount point. If the snapshot directory doesn't exits then it uses the first mount point; which is what is currently does.